Skip to content

Delete the Slice output manifest when the last Slice file is removed #4930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pepone merged 2 commits into from
Sep 11, 2026
Merged

Delete the Slice output manifest when the last Slice file is removed #4930

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f61874
Delete the Slice output manifest when the last Slice file is removed
pepone Sep 10, 2026
24b9058
Update src/IceRpc.Slice.Tools/IceRpc.Slice.Tools.targets
pepone Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/IceRpc.Slice.Tools/IceRpc.Slice.Tools.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,11 @@
<Compile Remove="@(_StaleSlicecOutputRelative)" />
</ItemGroup>
<Delete Files="@(_StaleSlicecOutput)" />
<!--
With no SliceFile left, _SlicecWriteOutputManifest doesn't run to replace the manifest; delete it here, or
every later build deletes whatever appears at the former output paths.
-->
Comment thread
pepone marked this conversation as resolved.
Outdated
<Delete Files="$(IntermediateOutputPath)slicec.outputs.txt" Condition="@(SliceFile) == ''" />
</Target>

<Target Name="Slicec" BeforeTargets="CoreCompile" DependsOnTargets="_ComputeSliceFiles" Condition="@(SliceFile) != ''">
Expand Down