Repository navigation
fix(credit): make credit reversal atomic and idempotent - #15
Merged
Merged
Conversation
|
Deployment failed for project rently-dashboard with the following error: Learn More: https://vercel.com/parmjeet-mishras-projects?upgradeToPro=build-rate-limit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements remediation slice B06 (docs/Fix-Plan-2026-09-05.md). Terra High review owed before [x].
Scope: one reversal per credit + atomic reversal-insert/original-update on Node and Neon paths. One migration (0028, partial unique index), no data rewrite.
Changes:
Behavior change: retry returns the pair instead of CONFLICT Already reversed (nothing depended on it).
Verification: db:generate no drift, check-types --force 6/6, Biome clean, db:migrate:test, full suite 236/236, local build 5/5. Dev has zero credit reversals.
Rollback: tag pre-atomic-credit-reversal on integ/phase-a-baseline@be7aca91.