[Hierarchies-react]: move to MUI by MartynasStrazdas · Pull Request #1425 · iTwin/presentation

MartynasStrazdas · 2026-07-02T08:07:17Z

No description provided.

changeset-bot · 2026-07-02T08:07:25Z

🦋 Changeset detected

Latest commit: d3ff108

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@itwin/presentation-hierarchies-react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

Pull request overview

This PR migrates @itwin/presentation-hierarchies-react’s StrataKit-based renderers from @stratakit/bricks / @stratakit/foundations UI primitives to MUI (@mui/material) via @stratakit/mui, and updates the monorepo dependency graph and tests accordingly.

Changes:

Add MUI / @stratakit/mui dependencies and update pnpm catalogs/lockfile to new StrataKit versions.
Replace several StrataKit UI primitives (buttons, text, inputs, menus, spinner) with MUI equivalents in the Stratakit renderers.
Adjust component tests and Vitest browser config for the new UI stack.

Reviewed changes

Copilot reviewed 11 out of 30 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
pnpm-workspace.yaml	Bumps Stratakit catalog versions and adds `@stratakit/mui` to the catalog.
pnpm-lock.yaml	Lockfile refresh reflecting the new MUI + Stratakit dependency graph.
packages/hierarchies-react/vitest.config.ts	Ensures Vitest browser pre-bundles `@mui/material` for component tests.
packages/hierarchies-react/src/test/components/TreeRenderer.test.tsx	Tweaks rendering/viewport sizing for context-menu visibility assertions.
packages/hierarchies-react/src/test/components/RenderUtils.tsx	Switches test theme root provider from `@stratakit/foundations` to `@stratakit/mui`.
packages/hierarchies-react/src/presentation-hierarchies-react/stratakit/TreeNodeRenderer.tsx	Replaces dropdown/context menu and label editor UI with MUI components.
packages/hierarchies-react/src/presentation-hierarchies-react/stratakit/TreeAction.tsx	Renders context-menu actions using MUI `MenuItem` + `@stratakit/mui` `Icon`.
packages/hierarchies-react/src/presentation-hierarchies-react/stratakit/RootErrorRenderer.tsx	Replaces error UI primitives with MUI equivalents.
packages/hierarchies-react/src/presentation-hierarchies-react/stratakit/ErrorItemRenderer.tsx	Replaces link/text primitives with MUI `Link`/`Typography`.
packages/hierarchies-react/package.json	Updates dependencies/peers to MUI + `@stratakit/mui` and drops old optional peers.
apps/test-app/frontend/package.json	Adds MUI + `@stratakit/mui` so the test app can consume the updated renderers.
.changeset/early-facts-hide.md	Adds a changeset documenting the migration and peer dependency changes.

Files not reviewed (1)

pnpm-lock.yaml: Generated file

Co-authored-by: MartynasStrazdas <43886789+MartynasStrazdas@users.noreply.github.com>

saskliutas · 2026-07-10T12:02:39Z

Looks like config for TypeScript is missing https://github.com/iTwin/stratakit/tree/main/packages/mui#typescript

MartynasStrazdas · 2026-07-13T07:27:38Z

Looks like config for TypeScript is missing https://github.com/iTwin/stratakit/tree/main/packages/mui#typescript

Added, ~~did not seem to affect anything~~ it deprecated component properties replaced them with render.

grigasp

Just to clarify, this has no breaking changes besides peer deps?

MartynasStrazdas · 2026-07-13T07:54:21Z

Just to clarify, this has no breaking changes besides peer deps?

Because we still use the tree from structures and have primarily replaced the stratakit/bricks components to MUI, there was no need for any api changes.

MartynasStrazdas · 2026-07-13T08:15:57Z

/update-screenshots

Co-authored-by: MartynasStrazdas <43886789+MartynasStrazdas@users.noreply.github.com>

grigasp · 2026-07-13T08:42:46Z

-      // `aria-required-children` is being triggered because anchor element of context menu is rendered next to `treeitem` under `tree` and
-      // it expects that `tree` contains only `treeitem` children.
+      await expect.element(page.getByText("Context Action 2")).toBeVisible();
      await validateSnapshot(locator, { skipA11y: ["aria-hidden-focus", "aria-required-children"] });


can you check if we still need skipA11y?

Seems to no longer be needed, removed.

There're a couple more usages of skipA11y in this test file - are they required?

grigasp

The initial load view lacks some spacing between the spinner and "Loading" text:

MartynasStrazdas · 2026-07-13T12:33:30Z

The initial load view lacks some spacing between the spinner and "Loading" text:

Quite interesting situation we had there where spinner was rendered in one component and loading text was in a sibling component (renderContent and renderLoadingOverlay), i don't think we need the renderLoadingOverlay so i removed it moving the spinner next to loading text. Also removed all itwinUI components in statelessTree, to remove can't remove the itwinUI entirely as some other packages still rely on it, will remove from other parts where possible in a different pr (talking about test-app) to have hierarchies-react version with MUI faster

initial

f68e3ba

MartynasStrazdas changed the title ~~initial~~ [Hierarchies-react]: move to MUI Jul 2, 2026

grigasp linked an issue Jul 3, 2026 that may be closed by this pull request

Migrate to @mui/material + @stratakit/mui #1148

Open

MartynasStrazdas added 6 commits July 3, 2026 10:30

Merge branch 'next' into mast/move-to-MUI

8141849

adjustments to context menu

be2238d

update button sizes

f1fd456

Merge branch 'next' into mast/move-to-MUI

19ee22d

fix context window behavior

44aa53e

change

7bfd1cd

MartynasStrazdas marked this pull request as ready for review July 9, 2026 08:35

MartynasStrazdas requested a review from a team as a code owner July 9, 2026 08:35

Copilot AI review requested due to automatic review settings July 9, 2026 08:35

Merge branch 'next' into mast/move-to-MUI

f9514b1

Copilot started reviewing on behalf of MartynasStrazdas July 9, 2026 08:35 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

MartynasStrazdas added 5 commits July 9, 2026 11:52

fixes

7eb4597

fixes

9364d1d

update to use catalog

cf198d2

lock file update

6724fc8

rerender all component tests

ac9cc23

saskliutas reviewed Jul 9, 2026

View reviewed changes

MartynasStrazdas and others added 4 commits July 9, 2026 15:31

fixes

1653e5b

Merge branch 'next' into mast/move-to-MUI

ee6683d

test: update visual regression screenshots

2c66480

Co-authored-by: MartynasStrazdas <43886789+MartynasStrazdas@users.noreply.github.com>

define our own onClick

57a5253

saskliutas reviewed Jul 9, 2026

View reviewed changes

Comment thread packages/hierarchies-react/src/presentation-hierarchies-react/stratakit/ErrorItemRenderer.tsx Outdated

MartynasStrazdas and others added 3 commits July 10, 2026 11:37

use Menu for context window

af2fe9d

Merge branch 'next' into mast/move-to-MUI

5d3d9a2

test: update visual regression screenshots

b69f666

Co-authored-by: MartynasStrazdas <43886789+MartynasStrazdas@users.noreply.github.com>

chore: add types for @stratakit/mui in tsconfig files

fceb885

grigasp reviewed Jul 13, 2026

View reviewed changes

MartynasStrazdas added 2 commits July 13, 2026 11:07

fix lint issues because of the addition of types from stratakit

70ea14d

format

d358a13

test: update visual regression screenshots

35a90f4

Co-authored-by: MartynasStrazdas <43886789+MartynasStrazdas@users.noreply.github.com>

grigasp reviewed Jul 13, 2026

View reviewed changes

spinner size adjustment

666055e

grigasp reviewed Jul 13, 2026

View reviewed changes

remove itwin ui from test app stateless tree

d3ff108

Uh oh!

Conversation

MartynasStrazdas commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

saskliutas commented Jul 10, 2026

Uh oh!

MartynasStrazdas commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grigasp left a comment

Choose a reason for hiding this comment

Uh oh!

MartynasStrazdas commented Jul 13, 2026

Uh oh!

MartynasStrazdas commented Jul 13, 2026

Uh oh!

Uh oh!

grigasp Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

MartynasStrazdas Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

grigasp Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

grigasp left a comment

Choose a reason for hiding this comment

Uh oh!

MartynasStrazdas commented Jul 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MartynasStrazdas commented Jul 2, 2026 •

edited

Loading

changeset-bot Bot commented Jul 2, 2026 •

edited

Loading

MartynasStrazdas commented Jul 13, 2026 •

edited

Loading