Repository navigation
Conversation
vaxerski
reviewed
Oct 19, 2026
vaxerski
left a comment
Member
There was a problem hiding this comment.
you should move all callers to Hyprutils::File::readFileAsString instead
Contributor
Author
So, I should use Hyprutils::File::readFileAsString function from here instead of NFsUtils::readFileAsString implementation? And I need to replace all NFsUtils::readFileAsString calls with Hyprutils::File::readFileAsString? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Simplified logic of readFileAsString function, removed redundant exists check, changed function signature from
std::stringtostd::filesystem::pathIs there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No.
Did you use AI in any way shape or form in the making of this PR? If so, detail how you used it. (Undisclosed AI use is a violation of the AI Policy and is punishable)
No.
Is it ready for merging, or does it need work?
Ready for merging. Tested locally on my machine.