Skip to content

protocols/text-input-v3: send done in response to every commit #16571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hjanuschka wants to merge 1 commit into from
+7 −0
Closed

protocols/text-input-v3: send done in response to every commit #16571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/protocols/TextInputV3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ CTextInputV3::CTextInputV3(SP<CZwpTextInputV3> resource_) : m_resource(resource_

m_pending.enabled.isEnablePending = false;
m_pending.enabled.isDisablePending = false;

// The serial in done must equal the number of commits, and clients
// hold back pending state (e.g. set_cursor_rectangle) until they
// receive a done with a matching serial. Ack every commit, otherwise
// clients that follow the spec strictly deadlock until the IM happens
// to push state back (updateIMEState).
sendDone();
});

m_resource->setSetSurroundingText([this](CZwpTextInputV3* r, const char* text, int32_t cursor, int32_t anchor) {
Expand Down
Loading