Repository navigation
Disable yuv - #16570
Merged
Merged
Disable yuv#16570
Conversation
|
FYI: If the hope was that clients stop sending YUV if it's disabled, Firefox re-enables them anyway in HDR mode: EnsureBasicFormat(GBM_FORMAT_P010);
EnsureBasicFormat(GBM_FORMAT_NV12);
EnsureBasicFormat(GBM_FORMAT_YUV420);And then happily keeps sending YUV anyway... |
Member
Author
|
that's a firefox bug and we could technically boot them out for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #16420
This is obviously not a proper solution, but it will do for now.
In the future we should fix our
externalsource shader probably and re-enable yuv.Might break clients that need yuv, but that's probably super rare, considering the bug report about this is rare too.