Repository navigation
Conversation
|
cc @kolayne |
|
whilst you're at it #15076 (comment) still partially borked, clicking on an empty monitor (follow_mouse 2) focuses the workspace but window on the other monitor remains focused |
|
I will try to look into it, but I won't include it in this PR. There seems to be a bunch of issues with multi-monitor focusing. Originally I wasn't even trying to fix this one: I wanted to fix #15649, but this came out on the way; the original bug that I was working on turned out to be rooted deeper, so I'm still waiting for @vaxerski's help at #15649 (comment). So, I would prefer to keep these patches atomic. |
|
This seems to make it required to specifically click an empty monitor after moving the mouse there to be able to open windows there with follow=1. That's not right. Definitely a ton of multi-monitor issues around, was just discussing on discord how pointer gets moved to 0,0 when a window rule puts a window on an empty workspace on non-active monitor, that's probably in the same family of issues caused by changeWorkspace refusing to focus empty monitors. |
Shit :( |
3767840 to
b1c69d2
Compare
b1c69d2 to
37ae2a8
Compare
|
Hey. I got a bit confused and I accidentally repurposed this PR, so it now solves a different relevant issue. As for the original issue, as well as the one mentioned by @fxzzi, I came up with a more neat solution, which I'll try to implement soon (though, it depends on this PR).
Seems fixed now. |
c17d6db to
d370eb6
Compare
Removes the mouse movement simulation after switching to a different workspace. This was causing the focus to jump back to the old workspace when cursor warp was not in use. Fixes hyprwm#15649
Describe your PR, what does it fix/add?
Fixes the ability to focus a workspace with no windows when
cursor:no_warps =true(#15649).Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No.
Is it ready for merging, or does it need work?
Yes.
Note: the PR is based on the last commit of main for which tests were passing.