Repository navigation
feat(mcp): advertise server title, description, website, and icon #3394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
27e954c
feat(mcp): advertise server title, description, website, and icon
brandon-pereira 9c9b6eb
feat(mcp): serve the HyperDX logo from the app instead of an inline SVG
brandon-pereira 16ac73d
fix(mcp): keep FRONTEND_URL sub-path in the server icon URL
brandon-pereira 3f87f27
test(mcp): drop eslint-disable from server metadata test
brandon-pereira e983afc
Merge branch 'main' into agent/mcp-server-metadata
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@hyperdx/api': patch | ||
| --- | ||
|
|
||
| feat(mcp): advertise a title, description, website URL, and SVG icon in the MCP server's initialize response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import type { Implementation } from '@modelcontextprotocol/sdk/types.js'; | ||
|
|
||
| import { McpContext } from '@/mcp/tools/types'; | ||
|
|
||
| const context: McpContext = { teamId: 'team-id', userId: 'user-id' }; | ||
|
|
||
| async function getServerInfo( | ||
| frontendUrl: string, | ||
| ): Promise<Implementation | undefined> { | ||
| let createTestClient!: typeof import('./mcpTestUtils').createTestClient; | ||
| jest.isolateModules(() => { | ||
| jest.doMock('@/config', () => ({ | ||
| ...jest.requireActual('@/config'), | ||
| FRONTEND_URL: frontendUrl, | ||
| })); | ||
| ({ createTestClient } = | ||
| jest.requireActual<typeof import('./mcpTestUtils')>('./mcpTestUtils')); | ||
| }); | ||
| jest.dontMock('@/config'); | ||
| const client = await createTestClient(context); | ||
| return client.getServerVersion(); | ||
| } | ||
|
|
||
| describe('MCP server metadata', () => { | ||
| it('advertises a title, description, website, and app-hosted icon', async () => { | ||
| const info = await getServerInfo('https://app.example.com/'); | ||
|
|
||
| expect(info).toMatchObject({ | ||
| name: 'clickstack', | ||
| title: 'ClickStack', | ||
| websiteUrl: expect.stringMatching(/^https:\/\//), | ||
| description: expect.any(String), | ||
| }); | ||
| expect(info?.icons).toEqual([ | ||
| { | ||
| src: 'https://app.example.com/favicons/hyperdx/favicon.svg', | ||
| mimeType: 'image/svg+xml', | ||
| sizes: ['any'], | ||
| }, | ||
| ]); | ||
| }); | ||
|
|
||
| it('keeps the FRONTEND_URL sub-path in the icon URL', async () => { | ||
| const info = await getServerInfo('https://host.example.com/hyperdx'); | ||
|
|
||
| expect(info?.icons?.[0]?.src).toBe( | ||
| 'https://host.example.com/hyperdx/favicons/hyperdx/favicon.svg', | ||
| ); | ||
| }); | ||
|
|
||
| it('omits the icon when FRONTEND_URL is unset', async () => { | ||
| const info = await getServerInfo(''); | ||
|
|
||
| expect(info?.title).toBe('ClickStack'); | ||
| expect(info?.icons).toBeUndefined(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.