Fix delayed macOS terminal frame presentation - #10
Open
rkzlyldrm wants to merge 1 commit into
Open
Conversation
Signed-off-by: rkzlyldrm <rkzlyldrm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A reported macOS failure accumulated typed input and PTY output in the terminal model but did not present the new frame until a later scroll event. WGPU 22 replaced winit's
NSViewroot layer withCAMetalLayer; upstream identified that layer-hosting mode as preventing winit from receiving the AppKit callbacks used to emitRedrawRequested. WGPU 23 changed the surface to a Metal sublayer: gfx-rs/wgpu#6107This keeps Hydra event-driven. It does not add a polling redraw loop or a frame watchdog.
Validation
cargo test --locked -p maestro-renderer -- --test-threads=1(903 passed)cargo clippy --locked -p maestro-renderer --all-targets -- -D warningscargo check --locked --workspace --all-targetspython3 scripts/verify-third-party-licenses.py(57 proofs)scripts/check-public-boundary.sh./scripts/build-local.sh --releasecargo fmt --all -- --checkgit diff --checkPhysical qualification remains required on the reporting Mac with a signed successor build: first typed input and first PTY output must appear without any scroll or pointer event.