Skip to content

Test clone requests on the early-enqueue path - #2471

Open
Crane-Liu wants to merge 1 commit into
hw-native-sys:mainfrom
Crane-Liu:codex/step3-clone-request-contract
Open

Crane-Liu wants to merge 1 commit into
hw-native-sys:mainfrom
Crane-Liu:codex/step3-clone-request-contract

Conversation

@Crane-Liu

@Crane-Liu Crane-Liu commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Add the Step 3 clone-request contract checks to the public Worker.submit early-enqueue path.

Part of #2429

Scope

  • Verify two independent submissions with the same request structure and request-private buffers.
  • Keep distinct output sentinels so result attribution and cross-run overwrite remain observable.
  • Assert distinct buffer identities, mapped addresses, run/task identities, and pipeline leases.
  • Exercise the staged submission through acceptance, completion, and release.
  • Preserve parent FIFO, serial operator execution, late-read, and refill behavior.

This PR contains test-contract coverage only. It does not add adapter code, DEVICE feedback, HBG distinct support, A5/TMR support, or runtime admission changes.

Validation

  • Rebased onto main at 833327f60ea8f4772bf1673ea8edb349314a350d.
  • Python compile and changed-file path scan passed.
  • Targeted C++ tests, Ruff, Ruff format, clang-format, and A3 host_build_graph validation passed before the rebase.
  • GitHub CI is running on the rebased head.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: b5baca71-b47a-468f-9961-660593c206d2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 0fa5c733-1de9-4b38-a0d0-4a8f122a7482

📥 Commits

Reviewing files that changed from the base of the PR and between 818ee04 and e44ae36.

📒 Files selected for processing (2)
  • tests/st/a2a3/host_build_graph/early_enqueue/test_early_enqueue.py
  • tests/ut/cpp/common/hierarchical/test_early_launch_admission.cpp

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The tests now use matching tensor inputs to check that separate runs retain distinct buffers and run identities. Unit tests also check task slots, pipeline leases, admission, completion, and release.

Changes

Clone run isolation and admission

Layer / File(s) Summary
Clone identity and admission validation
tests/ut/cpp/common/hierarchical/test_early_launch_admission.cpp, tests/st/a2a3/host_build_graph/early_enqueue/test_early_enqueue.py
Unit tests check matching tensor metadata, distinct run and buffer identities, task slots, pipeline leases, admission, completion, and release. The two-run test checks that matching input values use distinct buffers and base addresses.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to e44ae

This change adds coverage for clone-request isolation and admission without changing runtime behavior. No actionable issue warrants blocking the merge.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: adding tests for clone requests on the early-enqueue path.
Description check ✅ Passed The description directly explains the test coverage, scope, preserved behaviors, and validation for the early-enqueue clone-request changes.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks two runs in flight,
Their matching shapes, their buffers bright.
Distinct slots hold each run apart,
One grants the next its launch-start.
Then both complete, and leases depart.

Comment @coderabbitai help to get the list of available commands.

@Crane-Liu
Crane-Liu force-pushed the codex/step3-clone-request-contract branch 3 times, most recently from b0080e8 to ebe9c8a Compare September 30, 2026 08:10
Keep per-run output sentinels observable while checking independent buffer storage.

Verify distinct run, task, and lease identities through the full acceptance lifecycle.
@Crane-Liu
Crane-Liu force-pushed the codex/step3-clone-request-contract branch from ebe9c8a to 0095497 Compare September 30, 2026 10:03

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant