Bump https://github.com/astral-sh/ruff-pre-commit from v0.13.3 to 0.16.4 - #6957
Conversation
Bumps [https://github.com/astral-sh/ruff-pre-commit](https://github.com/astral-sh/ruff-pre-commit) from v0.13.3 to 0.16.4. - [Release notes](https://github.com/astral-sh/ruff-pre-commit/releases) - [Commits](astral-sh/ruff-pre-commit@v0.13.3...v0.16.4) --- updated-dependencies: - dependency-name: https://github.com/astral-sh/ruff-pre-commit dependency-version: 0.16.4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7ec9ee6. Configure here.
| repos: | ||
| - repo: https://github.com/astral-sh/ruff-pre-commit | ||
| rev: v0.13.3 | ||
| rev: v0.16.4 |
There was a problem hiding this comment.
Ruff bump expands enabled lint rules
High Severity
Bumping ruff-pre-commit to v0.16.4 expands Ruff's default rule set from 59 to 413 rules. pyproject.toml uses extend-select, which adds onto those defaults, so ruff-check with --fix will enforce and auto-apply many new categories the project never selected, failing quality CI and rewriting source.
Reviewed by Cursor Bugbot for commit 7ec9ee6. Configure here.
albertvillanova
left a comment
albertvillanova
left a comment
There was a problem hiding this comment.
Bugbot's finding here is correct, and it is why "Check code quality" is red.
Ruff 0.16.0 raised its default rule selection from 59 to 413 rules. Our pyproject.toml uses extend-select, which adds onto those defaults, so we silently inherit every newly defaulted family (BLE, SIM, S, TRY, LOG, DTZ, PL*, PIE, FURB, RUF, PYI, ...). Reproduced locally on this merge base, matching the job exactly:
Found 279 errors (66 fixed, 213 remaining).
7 files reformatted, 350 files left unchanged
There are two independent causes, and Bugbot flagged only the first:
- Lint. Switching
extend-selecttoselecttakes the hook back toAll checks passed!with no code changes at all. - Formatter. Ruff 0.15.0 changed formatter output, which reformats 2 files here regardless of the lint config. The other 5 in the count above are downstream of what
--fixhad already rewritten.
I would rather not take this bump. Within our own rule selection, ruff 0.13.3 and 0.16.4 report exactly the same thing on every tracked Python file, which is nothing, so the bump's only observable effect is churn plus 42 auto-rewritten files.
Two follow-ups instead:
- #6964 makes the rule set explicit (
selectinstead ofextend-select), so our lint results stop depending on which ruff version happens to be installed. Today a contributor running ruff 0.16.4 locally sees hundreds of errors that CI never reports. At the pinned 0.13.3 the change is a no-op: both configurations resolve to byte-identical sets of 170 enabled rules, and no default rule is dropped, since ruff's defaults live entirely insideEandFand we select both families whole. - #6965 stops dependabot from opening ruff bumps, while keeping doc-builder updates flowing (#6956).
I will close this PR once both are merged.
1 participant
Bumps https://github.com/astral-sh/ruff-pre-commit from v0.13.3 to 0.16.4.
Release notes
Sourced from https://github.com/astral-sh/ruff-pre-commit's releases.
... (truncated)
Commits
aab412dMirror: 0.16.465dbdb5Mirror: 0.16.37c55798Mirror: 0.16.26a246abBump astral-sh/setup-uv from 8.3.2 to 9.0.0 in the github-actions group (#179)39d9ac5Mirror: 0.16.1299cd31Bump actions/checkout from 7.0.0 to 7.0.1 in the github-actions group (#177)cb8c523Mirror: 0.16.0162e162Bump astral-sh/setup-uv from 8.2.0 to 8.3.2 in the github-actions group (#176)2700fd5Mirror: 0.15.2201a675eMirror: 0.15.21Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Low Risk
Dev-tooling-only pin change with no runtime code impact; the main follow-on risk is new or stricter Ruff checks or format output on the next hook run.
Overview
Updates the ruff-pre-commit pin in
.pre-commit-config.yamlfromv0.13.3tov0.16.4. Theruff-checkandruff-formathook definitions are unchanged; only the hook repo revision moves forward.This aligns local pre-commit and CI lint/format behavior with a newer Ruff release. After merging, the next pre-commit run may report additional fixes or formatting diffs compared to the older pin.
Reviewed by Cursor Bugbot for commit 7ec9ee6. Bugbot is set up for automated code reviews on this repo. Configure here.