Skip to content

Fixing DFlash test error #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ofirzaf wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Open

Fixing DFlash test error #1919

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd3ddb3
Update min version for dflash test to 2026.999 until it will get into…
ofirzaf Aug 7, 2026
6e57988
update comment
ofirzaf Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/openvino/test_genai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,7 @@ def test_compare_outputs(self, model_arch):
torch.testing.assert_close(transformers_output, genai_output, rtol=1e-2, atol=1e-3)


# NOTE: DFlash wasn't merge yet to an official release so skipping the tests for now
@pytest.mark.skipif(OPENVINO_DEVICE == "NPU", reason="Speculative decoding tests are not yet supported on NPU")
class LLMPipelineWithSpeculativeDecodingTestCase(unittest.TestCase):
GEN_KWARGS = {
Expand All @@ -581,7 +582,7 @@ class LLMPipelineWithSpeculativeDecodingTestCase(unittest.TestCase):
}
SPECULATIVE_DECODING_MODELS = [
(model_arch, model_pair, "Eagle3", None, "2026.0") for model_arch, model_pair in EAGLE3_MODELS.items()
] + [(model_arch, model_pair, "DFlash", "4.57", "2026.3") for model_arch, model_pair in DFLASH_MODELS.items()]
] + [(model_arch, model_pair, "DFlash", "4.57", "2026.999") for model_arch, model_pair in DFLASH_MODELS.items()]

@parameterized.expand(SPECULATIVE_DECODING_MODELS)
def test_compare_outputs(
Expand Down