[OpenVINO][Models] CohereASR conversion fix - #1910
Draft
PiotrKrzem wants to merge 6 commits into
Draft
Conversation
rkazants
reviewed
Aug 3, 2026
Comment on lines
+1115
to
+1118
| if task.startswith(("text2text-generation", "automatic-speech-recognition")) and ( | ||
| not task.endswith("with-past") or model.decoder.stateful | ||
| ): | ||
| expected_int8.pop("decoder_with_past", None) |
Collaborator
There was a problem hiding this comment.
I think it makes sense to execute only for cohereasr only to avoid impact on other ASR models
rkazants
reviewed
Aug 3, 2026
Collaborator
There was a problem hiding this comment.
use existing test suite in test_asr. No need to implement new test.
rkazants
reviewed
Aug 3, 2026
Comment on lines
+147
to
+159
| def _get_cohere_asr_test_model(): | ||
| # Falls back to a checkout local to the repository so the fixture can be regenerated offline | ||
| model_id_override = os.getenv("OPTIMUM_INTEL_COHERE_ASR_TEST_MODEL") | ||
| if model_id_override: | ||
| return model_id_override | ||
|
|
||
| local_fixture_path = Path(__file__).resolve().parents[3] / "tiny-random-cohere-asr" | ||
| if local_fixture_path.exists(): | ||
| return str(local_fixture_path) | ||
|
|
||
| return "optimum-intel-internal-testing/tiny-random-cohere-asr" | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
not needed, let us use tiny-model model from HF
rkazants
reviewed
Aug 3, 2026
rkazants
left a comment
rkazants
left a comment
Collaborator
There was a problem hiding this comment.
Please provide proper PR description. Check other PRs already merged, for ASR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue: