Skip to content

mamba-ssm: add layers - #1051

Merged
vasqu merged 6 commits into
mainfrom
mamba-layers
Aug 4, 2026
Merged

mamba-ssm: add layers#1051
vasqu merged 6 commits into
mainfrom
mamba-layers

Conversation

@vasqu

@vasqu vasqu commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

As per title WIP, adding layer variations for mamba2 and mamba1 so we can deprecate lazy load kernels

  • Mamba2
  • Mamba1

Also fixes a multi gpu issue under triton (the same we had under liger), ref. state-spaces/mamba#1003

@github-actions github-actions Bot added the chore Version bumps, releases, misc maintenance label Jul 30, 2026
@vasqu
vasqu marked this pull request as ready for review July 30, 2026 18:21
@vasqu
vasqu requested review from danieldk and sayakpaul July 30, 2026 18:21

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triton corruption may happen otherwise; similar to liger a few days/weeks back

A lot of ppl did different fixes but never the true underlying fix

sayakpaul
sayakpaul previously approved these changes Aug 1, 2026
Comment on lines +243 to +251
__all__ = [
"causal_conv1d_fn",
"causal_conv1d_update",
"mamba_inner_fn",
"mamba_split_conv1d_scan_combined",
"mamba_chunk_scan_combined",
"selective_state_update",
"selective_scan_fn",
]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding functions on a compiled kernels (so not no-arch like torch-cuda) requires a version bump, since otherwise, there will be old variants (Torch 2.10, Torch 2.11) that do not have these functions.

@vasqu
vasqu requested a review from danieldk August 4, 2026 11:19

@danieldk danieldk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@vasqu
vasqu merged commit df9aae1 into main Aug 4, 2026
4 of 5 checks passed
@vasqu
vasqu deleted the mamba-layers branch August 4, 2026 11:47
@vasqu

vasqu commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

/kernel-bot merge-and-upload mamba-ssm

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot merge-and-upload mamba-ssm
Mode: merge, build and upload
Target branch: ``
PR head SHA: 7b019b052037ecbbd1d37794f62036cc19e636a8
Workflows: `build.yaml, build-mac.yaml, build-windows.yaml`

Merge result: PR is already merged. Continuing with build/upload.

Dispatched (1):

Hub uploads:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Version bumps, releases, misc maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants