trace: each edge token gets its own file, so an earlier step opens the token then - #44
Merged
Merged
Conversation
…e token then A token that is not a path is written to `work/edge-tokens/` for the overlay and the queue trace to point at. There was one file per queue, rewritten by every token, so every step's last token on an edge pointed at the same file -- and opening it at an earlier step in the IDE's stepper showed the run's final token. Each token now gets its own file, numbered per queue (`<queue>__<n>.json`). Claude-Session: https://claude.ai/code/session_015VK7fH1c4aKbexnq2QcuKU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A token that is not a path is written to
work/edge-tokens/for the overlay and the queue trace to point at.The bug. There was one file per queue (
<queue>.json), rewritten by every token. So every step'slastTokenfor an edge pointed at the same file, and opening it at an earlier step in the IDE's stepper showed the run's final token. Follow-up to #43 and endrix/dialogram#61, which made stepping back redraw the edges.The fix. Each token now gets its own file, numbered per queue (
<queue>__<n>.json, counted inFifoPlan.edge_token_counts). Paths andFiletokens are unchanged; they were never copied.Test.
test_the_last_token_at_each_step_is_the_token_thenopens each step's last token on an edge and expects[1],[2],[3]in turn. It fails against the previous code. Full suite: 693 passed, 9 skipped.https://claude.ai/code/session_015VK7fH1c4aKbexnq2QcuKU