Update the way that detector splits are implemented in mapmaking - #973
Merged
Merged
Conversation
- Add functions to select and de-select detectors across all observations using temporary per-detector flags. This ensures that even for a combination of regex matching and focalplane splits, the correct detectors are used. - Simplify some of the setup functions in the mapmaker. - Add another unit test for making per-focalplane-pixel maps.
keskitalo
approved these changes
Aug 27, 2026
keskitalo
left a comment
keskitalo
left a comment
Member
There was a problem hiding this comment.
Excellent! Glad to have the new unit test added and passing.
- Remove use of deprecated observation view interface from mapmaker utils - When running the mapmaker on a subset of global detectors, propagate that list of names into utilities, without relying on per-detector flags. - Fix ad-hoc pair differencing mode in HWP stokes operator. - Fix regression in hit map coadd in toast_healpix_coadd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functions to select and de-select detectors across all
observations using temporary per-detector flags. This ensures
that even for a combination of regex matching and focalplane
splits, the correct detectors are used.
Simplify some of the setup functions in the mapmaker.
Add another unit test for making per-focalplane-pixel maps.