-
Notifications
You must be signed in to change notification settings - Fork 0
feat(ticktick): external task views — contract spike + hidden web/worker lanes #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| name: ticktick-live-smoke | ||
|
|
||
| # The plan's credentialed LIVE contract validation (docs/plans/ | ||
| # external-task-views-plan.md): deterministic tests use hand-authored wire | ||
| # values, so upstream TickTick schema/tool drift stays green locally — this job | ||
| # is the drift detector. Scheduled weekly + manually dispatchable; deliberately | ||
| # NOT part of the PR gate (needs a repo secret; must not hammer the live API). | ||
| # | ||
| # Two lanes, each through its production surface (review R10 #3): | ||
| # - OpenAPI (Web lane): the `#[ignore]`d Rust test `live_openapi_contract_smoke` | ||
| # runs the REAL decoder (reqwest → wire.rs → normalize) and asserts | ||
| # representative-shape counters (the smoke account stages due/tags/checklist). | ||
| # - MCP (Worker lane): scripts/ticktick-live-smoke.mjs asserts initialize + | ||
| # tools/list still offer the exact read allowlist. | ||
| # Both are non-capturing: counts/booleans only reach the log. | ||
|
|
||
| on: | ||
| schedule: | ||
| - cron: "17 6 * * 1" | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| smoke: | ||
| name: live-contract-smoke | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 20 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| with: | ||
| persist-credentials: false | ||
| - uses: dtolnay/rust-toolchain@stable | ||
| - uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| workspaces: "." | ||
| shared-key: core | ||
| - name: Smoke the OpenAPI lane through the production decoder | ||
| env: | ||
| TICKTICK_ACCESS_TOKEN: ${{ secrets.TICKTICK_ACCESS_TOKEN }} | ||
| run: > | ||
| cargo test --manifest-path crates/core/Cargo.toml | ||
| live_openapi_contract_smoke -- --ignored --nocapture | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 24 | ||
| - name: Smoke the MCP lane (initialize + tools/list allowlist) | ||
| env: | ||
| TICKTICK_ACCESS_TOKEN: ${{ secrets.TICKTICK_ACCESS_TOKEN }} | ||
| run: node scripts/ticktick-live-smoke.mjs | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win
Add a concurrency group.
The header states that the job must not hammer the live API. A manual
workflow_dispatchcan start while the weekly schedule run is still active, so two credentialed runs can hit TickTick at the same time. Add a concurrency group so a second run does not overlap.🛠️ Proposed change
on: schedule: - cron: "17 6 * * 1" workflow_dispatch: +concurrency: + group: ticktick-live-smoke + cancel-in-progress: false + permissions: contents: read📝 Committable suggestion
🧰 Tools
🪛 zizmor (1.29.0)
[warning] 17-20: insufficient job-level concurrency limits (concurrency-limits): workflow is missing concurrency setting
(concurrency-limits)
🤖 Prompt for AI Agents
Source: Linters/SAST tools