Fix release pipeline to use Trusted Publishers#4427
Open
allejo wants to merge 1 commit into
Open
Conversation
Build Size ReportChanges to minified artifacts in No changesNo existing files changed. |
arturict
reviewed
Jul 12, 2026
| run: | | ||
| echo We seem to be releasing `${RELEASING}`. | ||
| false | ||
| npm publish --tag ${{ env.NPM_TAG }} ${{ env.DRY_RUN_FLAG }} |
Contributor
There was a problem hiding this comment.
This publishes the repository root, not the generated Node package. The old action pointed at ./build/package.json; from this branch, a root npm pack --dry-run includes src/, test/, and tools/, while the package's main still points to ./lib/index.js (which only exists under build). The published package would be broken.
Should this be npm publish ./build --tag ...?
Contributor
|
Looks good. If CI policy changed, please include a quick note confirming no downstream pipeline regressions from release pipeline change. |
Member
|
@allejo see comment please :) @joshgoebel are you able to review please? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Josh, in your absence, I tagged and released 11.11.2 with all the already-merged PRs through July 2025. The new release could not be automatically published to npm or our CDN repo due to expired or revoked tokens (in December 2025, npm revoked all classic tokens).
Changes
I've logged in and configured the
highlight.jsand@highlightjs/cdn-assetspackages to use npm's new Trusted Publishers pattern.I've largely refactored the pipeline in this PR and removed a lot of the third-party actions that were previously used. The last hardcoded dry run of this action was successful. It's hard to test a production release pipeline, so I'm hoping you can serve as a second pair of eyes.
I also added a
workflow_dispatchso we can manually publish specific tags when our pipeline is broken and doesn't auto-publish, as in 11.11.2.Checklist
CHANGES.md