fix(input): keep prefix tab and escape keys with kitty associated text - #3057
fix(input): keep prefix tab and escape keys with kitty associated text#3057fraidev wants to merge 1 commit into
Conversation
Prefix mode enables kitty report-all with associated text. Hosts then send Tab, Shift+Tab, and Escape as CSI-u sequences with control associated text, which the 0.8.2 IME parser rejected as a whole key. Ignore control-only associated text so those prefix bindings still dispatch.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @fraidev, thanks for your interest in contributing. Herdr does not accept unsolicited implementation pull requests from contributors who are not listed in The pull request author is not an approved contributor. If you encountered a reproducible bug, report the observed behavior through the bug issue template. A report does not reserve the work or authorize a pull request; accepted fixes are normally implemented by Herdr’s maintainer-controlled agents. Feature requests, behavior changes, and other proposals belong in GitHub Discussions. Do not open an issue merely to justify an implementation that was already written. If a maintainer explicitly wants this implementation, they can reopen the pull request. Reopening by anyone else will be closed again automatically. See https://github.com/herdrdev/herdr/blob/master/CONTRIBUTING.md for the contribution policy. |
2 participants
After 0.8.2, prefix+tab, prefix+shift+tab, and prefix+esc stopped working for me. Prefix mode turns on Kitty report-all, and 0.8.2 also asks the host for associated text. Wezterm/Kitty then send Tab/Esc as CSI-u with the control character attached (\x1b[9;;9u, \x1b[9;2;9u, \x1b[27;;27u).
The IME parser treated that associated control text as malformed and dropped the whole key, so prefix mode never saw Tab or Esc. Configs like next_tab = "prefix+tab" and copy_mode = "prefix+esc" never ran.
This is separate from the prefix+esc lookup PR. Both are needed for prefix+esc after 0.8.2. Tab and Shift+Tab only need this one.