Repository navigation
chore: keep @types/node on the supported Node major - #3
Merged
Merged
Conversation
engines.node is ">=24" but Dependabot proposed @types/node 26.4.0. Types ahead of the runtime floor let source compile against APIs that are absent at runtime, so the failure surfaces for the user rather than in CI. Ignore major updates for @types/node so it tracks the 24.x line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
engines.nodeis">=24"in this package, but Dependabot proposed@types/node26.4.0.Types ahead of the runtime floor are a real hazard rather than a cosmetic mismatch: the compiler would accept calls to APIs that do not exist on Node 24, so the code type-checks clean in CI here and fails at runtime for anyone on the floor we advertise as supported. CI passing on the bump does not catch it, because CI does not run Node 24.
Keeps
@types/nodeon the 24.x line by ignoring major updates. Minor and patch updates still flow normally. When the floor moves to a newer Node, drop the rule and take the matching types major together.