ETT-1840: Fixes for title summary table - #101
Conversation
35203d6 to
7ba265e
Compare
moseshll
left a comment
There was a problem hiding this comment.
If I remove the binding.irb that is causing the tests to fail, I still get a failed test in solr_pivot_facets_spec.rb line 39 with 1319 not being in the 1400-200 range -- not sure if that's due to a change in the sample catalog or just to SolrPivotFacets fixes. I originally just wanted to capture that there would be "a lot" of rows, so maybe pushing the range to be_between(1000, 2000) would be supple enough.
I thought I already changed this, but maybe the commit got lost. Fix incoming... |
* Query by format: catalog currently includes many formats we don't want, and there's no way to facet on (say) the first value of the format field; we would need to index that separately, and may want to do so in the future * Add facet.limit=-1 to ensure we're getting all values * Add facet.missing=true so we get counts of items with one or more facets with null values
7ba265e to
a25a27b
Compare
|
Fixed & force-pushed. I'll re-request review once tests pass. |
moseshll
left a comment
There was a problem hiding this comment.
Looks good now. I would recommend following up with the change mentioned at the bottom of bin/refresh_title_summary_table.rb re SimpleCov since the updated version is complaining now, i.e., replace # :nocov: with a # simplecov:disable and # simplecov:enable pair.
This addresses the reported issue of having extraneous format values, since the catalog extracts additional formats from various MARC fields in addition to the format extracted from the leader in a similar style to hathifiles.
Along the way I also fixed a couple other issues:
Add facet.limit=-1 to ensure we're getting all values (the final count does differ and the tests will fail if that isn't there, subject to the vagaries of the sample catalog solr)
Add facet.missing=true so we get counts of items with one or more facets with null values (this we can test)