FE-1350: fix popover point positioning - #9189
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Popover now keeps point and cross-axis gap values current via refs + animation-frame listeners, applies flip-aware main-axis gaps through Autofocus gains Tooltip is split into an unstyled, exported Reviewed by Cursor Bugbot for commit eff00bb. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4e4eca5. Configure here.
lunelson
left a comment
There was a problem hiding this comment.
Looks good, although I don't quite get the "center" and "outside" position options
Those 2 story examples are poorly labeled/named. The 2 prop options are actually: And the center and outside examples are just test cases for positionFromPoint. positionFromPoint was specifically added for attaching a popover to an element inside a canvas (which has no dom node to connect to), which I needed in graph-viz, and almost all the tables in hash-app currently are virtualized in canvas too. |
|
Also, in case I haven't said this before - it's worth noting that ladle examples are actually the UI tests for the DS rather than documentation, the goal being to render out specific edge cases for visual testing + regressions. It also happens to have a lot of crossover with documenting the various features + props though, which is great while we don't have proper generated documentation yet - but it can mean that you'll sometimes see examples which are more for handling edge cases than real expected usage. |

🌟 What is the purpose of this PR?
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR: