-
Notifications
You must be signed in to change notification settings - Fork 123
FE-1322: Generate Petrinaut architecture docs from in-code annotations #9165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
kube
wants to merge
23
commits into
main
from
cf/fe-1322-generate-petrinaut-architecture-docs-from-in-code
Closed
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
e23e5d4
Add annotation-driven architecture docs generator
kube adbf4ec
Declare Petrinaut architecture layers in the source
kube ee30020
Commit the generated architecture bundle and a site to read it
kube 406b780
Exclude the architecture bundle from oxfmt
kube 72ec830
Stop versioning the generated architecture bundle
kube 07a8ae9
Migrate the illustrated architecture docs to authored MDX
kube 4210dd6
Emit diagrams only when the renderer is available
kube 7c4870a
Let authored pages attach to the layer they explain
kube ee20de1
Restore the architecture diagrams as importable components
kube f7a7839
Declare the generator's dependency on the packages it reads
kube 4de9508
Trim the architecture docs down to what is used
kube 8fc22ff
Address review: dual-license, shrink the logo, rename `seam`
kube a73501d
Remove an accidental scratch copy, and de-corrupt graph.ts
kube 567cfe1
Actually shrink the docs logo
kube 61abbf0
Drop speculative fields and simplify the declaration surface
kube 000eee7
Add an interactive, collapsible layer map
kube 0ab1c8f
State every requirement the bundle places on a host
kube 83d64b6
Move the docs build into the task graph
kube 720a447
Make the layer map's nodes clickable at all
kube 9d9c77c
Draw the layer map ourselves instead of driving an editor
kube b9ae0fc
Fail on a configured package nothing can extract
kube e3b529c
Replace the layer map with a diagram per layer
kube 33ad762
Cut the vocabulary to what places a node in the graph
kube File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Copied from the architecture bundle by scripts/sync-bundle.mjs. The bundle in | ||
| # libs/@local/petrinaut-arch-docs/bundle is the committed artefact; this is a | ||
| # build input derived from it. | ||
| src/content/docs/ | ||
| src/content/diagrams/ | ||
| src/content/components/ | ||
| public/architecture.md | ||
| public/architecture.json | ||
|
|
||
| dist/ | ||
| .astro/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,189 @@ | ||
| # Apache License | ||
|
|
||
| _Version 2.0, January 2004_ | ||
| _<<http://www.apache.org/licenses/>>_ | ||
|
|
||
| ### Terms and Conditions for use, reproduction, and distribution | ||
|
|
||
| #### 1. Definitions | ||
|
|
||
| βLicenseβ shall mean the terms and conditions for use, reproduction, and | ||
| distribution as defined by Sections 1 through 9 of this document. | ||
|
|
||
| βLicensorβ shall mean the copyright owner or entity authorized by the copyright | ||
| owner that is granting the License. | ||
|
|
||
| βLegal Entityβ shall mean the union of the acting entity and all other entities | ||
| that control, are controlled by, or are under common control with that entity. | ||
| For the purposes of this definition, βcontrolβ means **(i)** the power, direct or | ||
| indirect, to cause the direction or management of such entity, whether by | ||
| contract or otherwise, or **(ii)** ownership of fifty percent (50%) or more of the | ||
| outstanding shares, or **(iii)** beneficial ownership of such entity. | ||
|
|
||
| βYouβ (or βYourβ) shall mean an individual or Legal Entity exercising | ||
| permissions granted by this License. | ||
|
|
||
| βSourceβ form shall mean the preferred form for making modifications, including | ||
| but not limited to software source code, documentation source, and configuration | ||
| files. | ||
|
|
||
| βObjectβ form shall mean any form resulting from mechanical transformation or | ||
| translation of a Source form, including but not limited to compiled object code, | ||
| generated documentation, and conversions to other media types. | ||
|
|
||
| βWorkβ shall mean the work of authorship, whether in Source or Object form, made | ||
| available under the License, as indicated by a copyright notice that is included | ||
| in or attached to the work (an example is provided in the Appendix below). | ||
|
|
||
| βDerivative Worksβ shall mean any work, whether in Source or Object form, that | ||
| is based on (or derived from) the Work and for which the editorial revisions, | ||
| annotations, elaborations, or other modifications represent, as a whole, an | ||
| original work of authorship. For the purposes of this License, Derivative Works | ||
| shall not include works that remain separable from, or merely link (or bind by | ||
| name) to the interfaces of, the Work and Derivative Works thereof. | ||
|
|
||
| βContributionβ shall mean any work of authorship, including the original version | ||
| of the Work and any modifications or additions to that Work or Derivative Works | ||
| thereof, that is intentionally submitted to Licensor for inclusion in the Work | ||
| by the copyright owner or by an individual or Legal Entity authorized to submit | ||
| on behalf of the copyright owner. For the purposes of this definition, | ||
| βsubmittedβ means any form of electronic, verbal, or written communication sent | ||
| to the Licensor or its representatives, including but not limited to | ||
| communication on electronic mailing lists, source code control systems, and | ||
| issue tracking systems that are managed by, or on behalf of, the Licensor for | ||
| the purpose of discussing and improving the Work, but excluding communication | ||
| that is conspicuously marked or otherwise designated in writing by the copyright | ||
| owner as βNot a Contribution.β | ||
|
|
||
| βContributorβ shall mean Licensor and any individual or Legal Entity on behalf | ||
| of whom a Contribution has been received by Licensor and subsequently | ||
| incorporated within the Work. | ||
|
|
||
| #### 2. Grant of Copyright License | ||
|
|
||
| Subject to the terms and conditions of this License, each Contributor hereby | ||
| grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, | ||
| irrevocable copyright license to reproduce, prepare Derivative Works of, | ||
| publicly display, publicly perform, sublicense, and distribute the Work and such | ||
| Derivative Works in Source or Object form. | ||
|
|
||
| #### 3. Grant of Patent License | ||
|
|
||
| Subject to the terms and conditions of this License, each Contributor hereby | ||
| grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, | ||
| irrevocable (except as stated in this section) patent license to make, have | ||
| made, use, offer to sell, sell, import, and otherwise transfer the Work, where | ||
| such license applies only to those patent claims licensable by such Contributor | ||
| that are necessarily infringed by their Contribution(s) alone or by combination | ||
| of their Contribution(s) with the Work to which such Contribution(s) was | ||
| submitted. If You institute patent litigation against any entity (including a | ||
| cross-claim or counterclaim in a lawsuit) alleging that the Work or a | ||
| Contribution incorporated within the Work constitutes direct or contributory | ||
| patent infringement, then any patent licenses granted to You under this License | ||
| for that Work shall terminate as of the date such litigation is filed. | ||
|
|
||
| #### 4. Redistribution | ||
|
|
||
| You may reproduce and distribute copies of the Work or Derivative Works thereof | ||
| in any medium, with or without modifications, and in Source or Object form, | ||
| provided that You meet the following conditions: | ||
|
|
||
| - **(a)** You must give any other recipients of the Work or Derivative Works a copy of | ||
| this License; and | ||
| - **(b)** You must cause any modified files to carry prominent notices stating that You | ||
| changed the files; and | ||
| - **(c)** You must retain, in the Source form of any Derivative Works that You distribute, | ||
| all copyright, patent, trademark, and attribution notices from the Source form | ||
| of the Work, excluding those notices that do not pertain to any part of the | ||
| Derivative Works; and | ||
| - **(d)** If the Work includes a βNOTICEβ text file as part of its distribution, then any | ||
| Derivative Works that You distribute must include a readable copy of the | ||
| attribution notices contained within such NOTICE file, excluding those notices | ||
| that do not pertain to any part of the Derivative Works, in at least one of the | ||
| following places: within a NOTICE text file distributed as part of the | ||
| Derivative Works; within the Source form or documentation, if provided along | ||
| with the Derivative Works; or, within a display generated by the Derivative | ||
| Works, if and wherever such third-party notices normally appear. The contents of | ||
| the NOTICE file are for informational purposes only and do not modify the | ||
| License. You may add Your own attribution notices within Derivative Works that | ||
| You distribute, alongside or as an addendum to the NOTICE text from the Work, | ||
| provided that such additional attribution notices cannot be construed as | ||
| modifying the License. | ||
|
|
||
| You may add Your own copyright statement to Your modifications and may provide | ||
| additional or different license terms and conditions for use, reproduction, or | ||
| distribution of Your modifications, or for any such Derivative Works as a whole, | ||
| provided Your use, reproduction, and distribution of the Work otherwise complies | ||
| with the conditions stated in this License. | ||
|
|
||
| #### 5. Submission of Contributions | ||
|
|
||
| Unless You explicitly state otherwise, any Contribution intentionally submitted | ||
| for inclusion in the Work by You to the Licensor shall be under the terms and | ||
| conditions of this License, without any additional terms or conditions. | ||
| Notwithstanding the above, nothing herein shall supersede or modify the terms of | ||
| any separate license agreement you may have executed with Licensor regarding | ||
| such Contributions. | ||
|
|
||
| #### 6. Trademarks | ||
|
|
||
| This License does not grant permission to use the trade names, trademarks, | ||
| service marks, or product names of the Licensor, except as required for | ||
| reasonable and customary use in describing the origin of the Work and | ||
| reproducing the content of the NOTICE file. | ||
|
|
||
| #### 7. Disclaimer of Warranty | ||
|
|
||
| Unless required by applicable law or agreed to in writing, Licensor provides the | ||
| Work (and each Contributor provides its Contributions) on an βAS ISβ BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, | ||
| including, without limitation, any warranties or conditions of TITLE, | ||
| NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are | ||
| solely responsible for determining the appropriateness of using or | ||
| redistributing the Work and assume any risks associated with Your exercise of | ||
| permissions under this License. | ||
|
|
||
| #### 8. Limitation of Liability | ||
|
|
||
| In no event and under no legal theory, whether in tort (including negligence), | ||
| contract, or otherwise, unless required by applicable law (such as deliberate | ||
| and grossly negligent acts) or agreed to in writing, shall any Contributor be | ||
| liable to You for damages, including any direct, indirect, special, incidental, | ||
| or consequential damages of any character arising as a result of this License or | ||
| out of the use or inability to use the Work (including but not limited to | ||
| damages for loss of goodwill, work stoppage, computer failure or malfunction, or | ||
| any and all other commercial damages or losses), even if such Contributor has | ||
| been advised of the possibility of such damages. | ||
|
|
||
| #### 9. Accepting Warranty or Additional Liability | ||
|
|
||
| While redistributing the Work or Derivative Works thereof, You may choose to | ||
| offer, and charge a fee for, acceptance of support, warranty, indemnity, or | ||
| other liability obligations and/or rights consistent with this License. However, | ||
| in accepting such obligations, You may act only on Your own behalf and on Your | ||
| sole responsibility, not on behalf of any other Contributor, and only if You | ||
| agree to indemnify, defend, and hold each Contributor harmless for any liability | ||
| incurred by, or claims asserted against, such Contributor by reason of your | ||
| accepting any such warranty or additional liability. | ||
|
|
||
| _END OF TERMS AND CONDITIONS_ | ||
|
|
||
| ### APPENDIX: Apply the Apache License to a specific file | ||
|
|
||
| To apply the Apache License to an individual file, attach the following notice. | ||
| The text should be enclosed in the appropriate comment syntax for the file | ||
| format. | ||
|
|
||
| Copyright Β© 2025β, HASH | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # MIT License | ||
|
|
||
| Copyright Β© 2025β, HASH | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # License | ||
|
|
||
| Licensed under either of the [Apache License, Version 2.0](LICENSE-APACHE.md) or [MIT license](LICENSE-MIT.md) at your option. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| # `@apps/petrinaut-docs` | ||
|
|
||
| Renders the Petrinaut architecture bundle as a browsable [Starlight](https://starlight.astro.build) | ||
| site. | ||
|
|
||
| **Run it through Turborepo**, which is what knows the site needs a freshly | ||
| generated bundle: | ||
|
|
||
| ```sh | ||
| turbo run dev --filter @apps/petrinaut-docs # browse at http://localhost:4321 | ||
| turbo run build --filter @apps/petrinaut-docs # static output in dist/ | ||
| ``` | ||
|
|
||
| `yarn workspace @apps/petrinaut-docs dev` runs the package script directly and | ||
| skips the task graph, so it renders whatever was last synced. | ||
|
|
||
| ## This app owns no content | ||
|
|
||
| Every page comes from the bundle generated by `@local/petrinaut-arch-docs`. | ||
| `scripts/sync-bundle.mjs` copies that bundle into `src/content/`; generating it | ||
| is the generator's own `doc:architecture` task, which `sync:bundle` declares as a | ||
| dependency. The bundle is build output and is not committed. | ||
|
|
||
| `build`, `lint:tsc` and `dev` all depend on one shared `sync:bundle` rather than | ||
| each running it β they used to call it themselves, which raced when Turborepo ran | ||
| them concurrently on the same directories. | ||
|
|
||
| That separation is deliberate. The bundle has to render in a host that did not | ||
| generate it β hash.dev is the other one β so this site is a test of the bundle's | ||
| portability as much as a way to read it. Anything that only works here is a bug | ||
| in the bundle. | ||
|
|
||
| To change what the docs say, change the annotations in the Petrinaut source or | ||
| the authored pages in `libs/@local/petrinaut-arch-docs/content/`. Anything run | ||
| through Turborepo picks the change up; to regenerate the bundle on its own: | ||
|
|
||
| ```sh | ||
| turbo run doc:architecture --filter @local/petrinaut-arch-docs | ||
| ``` | ||
|
|
||
| ## Why the bundle is copied rather than read in place | ||
|
|
||
| Pointing Astro's `glob` loader at the bundle directory works for `astro build`, | ||
| but not for `astro dev`: in dev, Astro resolves an MDX page's relative image | ||
| paths against the project root, so `../diagrams/core.svg` cannot be found. | ||
| Copying sidesteps that, and matches what an embedding host does anyway. | ||
|
|
||
| The copied directories (`src/content/docs`, `src/content/diagrams`) are | ||
| gitignored, as is the bundle they come from. Nothing generated is versioned. | ||
|
|
||
| ## Notes on configuration | ||
|
|
||
| Authored pages are optional. When `content/` in the generator package is empty | ||
| or absent, there is no authored home page, so `/` redirects to the generated | ||
| architecture overview instead. | ||
|
|
||
| `trailingSlash: "never"` and `build.format: "file"` are load-bearing, not | ||
| stylistic. The bundle's inter-page links are relative and assume a page's slug | ||
| maps to a URL with no trailing slash; serving `/architecture/core/` instead would | ||
| resolve those links one level too deep. | ||
|
|
||
| `installConfig.hoistingLimits` nests this app's dependencies rather than hoisting | ||
| them. Astro's generated prerender entry resolves `cookie` from this app's build | ||
| output, which would otherwise reach the root-hoisted `cookie@0.7.2` that | ||
| `express` pins and fail on a missing `parseCookie` export. Nesting keeps Astro on | ||
| its own `cookie@2.x` without changing hoisting for the rest of the monorepo. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thee docs need switching from AGPLv3 to Apache 2.0/MIT dual-license.