MCP - Prompt infra#3971
Open
zamoore wants to merge 7 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1776a6b to
b1221f1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds initial scaffolding in the packages/mcp package to support registering MCP prompts at server startup, establishing a typed prompt definition and a centralized registration function.
Changes:
- Introduces a typed
McpPromptinterface to standardize prompt name/config/callback shapes. - Adds a
registerPrompts(server)entrypoint with a centralPROMPTSregistry (currently empty). - Wires prompt registration into MCP server startup before connecting the stdio transport.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/mcp/src/prompts/types.ts | Adds the McpPrompt type definition for consistent prompt configuration and callback typing. |
| packages/mcp/src/prompts/index.ts | Introduces a central PROMPTS registry and a registerPrompts function that registers all prompts with the server. |
| packages/mcp/src/index.ts | Calls registerPrompts(server) during server initialization prior to transport connection. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR adds MCP prompt-registration infrastructure and wires it into server startup.
🛠️ Detailed description
registerPrompts(server)inpackages/mcp/src/prompts/index.tswith a centralPROMPTSregistry (currently empty) and loops through it to register prompts.McpPrompttyping inpackages/mcp/src/prompts/types.tsfor prompt name/config/callback shape consistency.packages/mcp/src/index.tsto import and invokeregisterPrompts(server)before connecting transport.packages/mcp/src/index.ts.McpPrompttype constraints and compatibility withserver.registerPrompt(...).packages/mcp/src/prompts/index.tsandpackages/mcp/src/prompts/types.ts.🔗 External links
Jira ticket: HDS-6501
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.