Skip to content

MCP - Prompt infra#3971

Open
zamoore wants to merge 7 commits into
mainfrom
zamoore/hds-6501/mcp_prompt-infra
Open

MCP - Prompt infra#3971
zamoore wants to merge 7 commits into
mainfrom
zamoore/hds-6501/mcp_prompt-infra

Conversation

@zamoore

@zamoore zamoore commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

📌 Summary

If merged, this PR adds MCP prompt-registration infrastructure and wires it into server startup.

🛠️ Detailed description

  • Adds registerPrompts(server) in packages/mcp/src/prompts/index.ts with a central PROMPTS registry (currently empty) and loops through it to register prompts.
  • Introduces McpPrompt typing in packages/mcp/src/prompts/types.ts for prompt name/config/callback shape consistency.
  • Updates MCP server bootstrap in packages/mcp/src/index.ts to import and invoke registerPrompts(server) before connecting transport.
  • No behavior change yet for end users: this is scaffolding to support adding concrete MCP prompts in follow-up PRs.

:copilot: Copilot instructions

  • Confirm prompt registration is initialized at the correct lifecycle point in packages/mcp/src/index.ts.
  • Validate McpPrompt type constraints and compatibility with server.registerPrompt(...).
  • Check for module-resolution/type import issues in packages/mcp/src/prompts/index.ts and packages/mcp/src/prompts/types.ts.

🔗 External links

Jira ticket: HDS-6501
Figma file: [if it applies]


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hds-showcase Ready Ready Preview Jul 7, 2026 3:26pm
hds-website Ready Ready Preview Jul 7, 2026 3:26pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds initial scaffolding in the packages/mcp package to support registering MCP prompts at server startup, establishing a typed prompt definition and a centralized registration function.

Changes:

  • Introduces a typed McpPrompt interface to standardize prompt name/config/callback shapes.
  • Adds a registerPrompts(server) entrypoint with a central PROMPTS registry (currently empty).
  • Wires prompt registration into MCP server startup before connecting the stdio transport.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/mcp/src/prompts/types.ts Adds the McpPrompt type definition for consistent prompt configuration and callback typing.
packages/mcp/src/prompts/index.ts Introduces a central PROMPTS registry and a registerPrompts function that registers all prompts with the server.
packages/mcp/src/index.ts Calls registerPrompts(server) during server initialization prior to transport connection.

Comment thread packages/mcp/src/prompts/index.ts Outdated
Comment thread packages/mcp/src/index.ts
zamoore and others added 2 commits July 7, 2026 11:22
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants