MCP - Tools infrastructure#3970
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5c25216 to
38aa2f6
Compare
dac52f9 to
db3ae54
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
263a64d to
b648176
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds initial scaffolding to support MCP tool registration in the packages/mcp server, establishing a central registry and shared tool typing so future tools can be added consistently.
Changes:
- Calls
registerTools(server)during MCP server bootstrap. - Introduces a
tools/registry module with a registration loop. - Adds a shared
McpToolinterface to standardize tool metadata and callbacks.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/mcp/src/index.ts | Invokes tool registration as part of server construction. |
| packages/mcp/src/tools/index.ts | Adds a central registry and iterates it to register tools with the server. |
| packages/mcp/src/tools/types.ts | Defines the McpTool interface for tool definitions and callback typing. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR wires in MCP tool registration and adds the initial shared tool infrastructure/types for future tool implementations.
🛠️ Detailed description
packages/mcp/src/index.tsto callregisterTools(server)during server setup.packages/mcp/src/tools/index.tswith a centralized TOOLS registry and registration loop.packages/mcp/src/tools/types.tswith a typedMcpToolinterface (name/config/callback) based on MCP SDK types.Review for:
McpTool,Jira ticket: HDS-6495
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.