Skip to content

MCP - Tools infrastructure#3970

Merged
zamoore merged 13 commits into
mainfrom
zamoore/hds-6495/mcp_tools-infra
Jul 9, 2026
Merged

MCP - Tools infrastructure#3970
zamoore merged 13 commits into
mainfrom
zamoore/hds-6495/mcp_tools-infra

Conversation

@zamoore

@zamoore zamoore commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

📌 Summary

If merged, this PR wires in MCP tool registration and adds the initial shared tool infrastructure/types for future tool implementations.

🛠️ Detailed description

  • Updates packages/mcp/src/index.ts to call registerTools(server) during server setup.
  • Adds packages/mcp/src/tools/index.ts with a centralized TOOLS registry and registration loop.
  • Adds packages/mcp/src/tools/types.ts with a typed McpTool interface (name/config/callback) based on MCP SDK types.
  • No concrete tools are added yet; this is scaffolding for upcoming MCP tools.

:copilot: Copilot instructions

Review for:

  • type safety and SDK type compatibility in McpTool,
  • correct registration flow/order in server bootstrap,
  • extensibility of the tools registry pattern for adding real tools next.

Jira ticket: HDS-6495


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hds-showcase Ready Ready Preview Jul 7, 2026 2:56pm
hds-website Ready Ready Preview Jul 7, 2026 2:56pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds initial scaffolding to support MCP tool registration in the packages/mcp server, establishing a central registry and shared tool typing so future tools can be added consistently.

Changes:

  • Calls registerTools(server) during MCP server bootstrap.
  • Introduces a tools/ registry module with a registration loop.
  • Adds a shared McpTool interface to standardize tool metadata and callbacks.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/mcp/src/index.ts Invokes tool registration as part of server construction.
packages/mcp/src/tools/index.ts Adds a central registry and iterates it to register tools with the server.
packages/mcp/src/tools/types.ts Defines the McpTool interface for tool definitions and callback typing.

Comment thread packages/mcp/src/tools/types.ts
Comment thread packages/mcp/src/tools/index.ts
zamoore and others added 2 commits July 7, 2026 10:51
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@MelSumner MelSumner left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zamoore zamoore merged commit 18cc0ba into main Jul 9, 2026
12 checks passed
@zamoore zamoore deleted the zamoore/hds-6495/mcp_tools-infra branch July 9, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants