Skip to content

Component catalog - Accordion#3965

Open
zamoore wants to merge 2 commits into
mainfrom
zamoore/hds-6500/component-catalog_accordion-group
Open

Component catalog - Accordion#3965
zamoore wants to merge 2 commits into
mainfrom
zamoore/hds-6500/component-catalog_accordion-group

Conversation

@zamoore

@zamoore zamoore commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

📌 Summary

If merged, this PR documents the Accordion component group in the MCP component manifest file.

:copilot: Copilot instructions

  • Treat packages/mcp/src/catalogs/components/catalog.json as generated data; review source-of-truth docs/types, not prose style preferences.
  • For component/arg/yield description, verify it matches website/docs/components/**/partials/code/component-api.md wording and meaning (no invented behavior).
  • For default, require exact match to docs <C.Property ... @default="..."> when present; missing or different defaults are errors.
  • For args, avoid duplicate info in description that is already encoded in type/default; keep behavioral nuance and constraints.
  • For blocks, allow only name and yields; block-level descriptions should not be added.
  • For yields, confirm name, type, kind, componentName, and boundArgs come from component signature parsing (packages/components/scripts/generate-component-catalog.mjs), not guessed from docs.
  • If docs claim contextual yields not present in parsed signatures, classify as docs inconsistency (non-blocking) rather than schema/content corruption.
  • Flag placeholders like "description": "TODO" as failures: enrichment did not resolve docs content.
  • Ensure final catalog conforms to packages/mcp/src/catalogs/components/schema.ts; schema-valid output is required before accepting additions.
  • Prefer exact docs text (minus context-only phrases like “see below”) over paraphrased rewrites when filling descriptions.

📸 Screenshots

🔗 External links

Jira ticket: HDS-6500
Figma file: [if it applies]


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel

vercel Bot commented Jul 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hds-showcase Ready Ready Preview Jul 2, 2026 1:33am
hds-website Ready Ready Preview Jul 2, 2026 1:33am

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds initial MCP component catalog data for the Accordion component group, alongside a Zod schema intended to validate the catalog structure in packages/mcp.

Changes:

  • Introduces a Zod schema for the MCP components catalog (componentCatalogSchema).
  • Adds catalog.json entries for HdsAccordion and HdsAccordionItem, including args, blocks, and yields metadata.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
packages/mcp/src/catalogs/components/schema.ts Adds Zod schema/types for validating a component catalog payload.
packages/mcp/src/catalogs/components/catalog.json Adds Accordion + Accordion::Item catalog entries (args/blocks/yields) for MCP consumption.

Comment thread packages/mcp/src/catalogs/components/catalog.json Outdated
Comment thread packages/mcp/src/catalogs/components/catalog.json
Comment thread packages/mcp/src/catalogs/components/catalog.json
Comment thread packages/mcp/src/catalogs/components/catalog.json
Comment thread packages/mcp/src/catalogs/components/catalog.json Outdated
@zamoore zamoore changed the title added catalog for accordion Component catalog - Accordion Jul 1, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants