Project solar/phase 1/forms controls#3911
Draft
KristinLBradley wants to merge 39 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hashibot-hds
added
packages/components
docs-website
didoo
changed the base branch from
main
to
project-solar/phase-1-main-feature-branch
didoo
force-pushed
the
project-solar/phase-1-main-feature-branch
branch
from
b0faa01 to
0f7c918
Compare
didoo
force-pushed
the
project-solar/phase-1/forms-controls
branch
from
a00c188 to
da9e8f6
Compare
KristinLBradley
force-pushed
the
project-solar/phase-1/forms-controls
branch
from
da9e8f6 to
3fb02ec
Compare
KristinLBradley
force-pushed
the
project-solar/phase-1/forms-controls
branch
from
3fb02ec to
13a1c66
Compare
KristinLBradley
force-pushed
the
project-solar/phase-1/forms-controls
branch
from
13a1c66 to
6810bba
Compare
KristinLBradley
force-pushed
the
project-solar/phase-1/forms-controls
branch
from
6810bba to
a00b351
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
…hemes to match carbon component styles
…s, update Showcase examples, re-order some input types to better group similar ones together
…sition-x token to add values
…bon examples which don't show state properly
…lving remaining issues
…e CSS mask-images and simplify CSS
…failing integration tests for FilterBar
Apply suggestions from code review
…con for invalid states and delete wrapper span around input
…der, etc from feedback Make adjustments to carbonized TextInput widths, hover styles for border, etc from feedback
…me styles and design tokens for FileInput, update FileInput Carbonization Showcase examples
…eckbox carbonizatin showcase examples
…s, fix linting issue
…content examples Update focus outline offset for Select carbon themes and consolidate content examples
…d preliminary theming styles for Radio
…round sizing, add hover background colors
Regenerate files in output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
📌 Summary
If merged, this PR adds carbonized Form control components to the carbonization branch.
Previews:
TextInput: https://hds-showcase-git-project-solar-phase-1forms-controls-hashicorp.vercel.app/carbonization/components/form/text-inputFileInput: https://hds-showcase-git-project-solar-phase-1forms-controls-hashicorp.vercel.app/carbonization/components/form/file-inputCheckbox: https://hds-showcase-git-project-solar-phase-1forms-controls-hashicorp.vercel.app/carbonization/components/form/checkboxSelect: https://hds-showcase-git-project-solar-phase-1forms-controls-hashicorp.vercel.app/carbonization/components/form/selectRadio: https://hds-showcase-git-project-solar-phase-1forms-controls-hashicorp.vercel.app/carbonization/components/form/radioTextarea: https://hds-showcase-git-project-solar-phase-1forms-controls-hashicorp.vercel.app/carbonization/components/form/textareaMaskedInput: https://hds-showcase-git-project-solar-phase-1forms-controls-hashicorp.vercel.app/carbonization/components/form/masked-input🛠️ Detailed description
Related:
Formprimitives (HDS-6086) #3860📸 Screenshots
TextInput, partial screenshot:
👀 Component checklist
[ ] A changelog entry was added via [Changesets](https://github.com/changesets/changesets) if needed (see templates here)💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.