test: cover DBOPS changeset validation, diagnose step guard, CCM filters#695
Draft
cursor[bot] wants to merge 1 commit into
Draft
test: cover DBOPS changeset validation, diagnose step guard, CCM filters#695cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add regression tests for recently merged production paths: - database_changeset_existence: reject missing/empty/invalid ids, 100-id limit, changeSetIds alias, and whitespace trimming before API call - harness_diagnose pipeline: suppress all_step_logs when step_id is set so single-step URLs stay in single-step mode (#691) - cost_recommendation_count/stats: paired cost_category + cost_buckets guard matching list behavior (#617) Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Daily test-coverage automation run targeting recently merged production paths with weak or missing regression tests.
Risky behavior now covered
database_changeset_existencebodyBuilder validation ([feat]: [DBOPS-2684]: DBOPS changeset existence check API addition #679) — rejects missing/emptychangeset_ids, >100 ids, non-string/blank entries; acceptschangeSetIdsalias; trims whitespace before API call.harness_diagnosepipeline single-step guard (feat: unify pipeline_summarizer into failure+success analyzer with RCA #691) — whenstep_idis present,include_all_step_logsis suppressed so single-step URLs do not leak whole-pipeline logs or confuse downstream summarizer mode detection.cost_categorywithoutcost_bucketsdoes not emitcostCategoryDTOs, matching existing list behavior.Test files added/updated
tests/registry/dbops.test.ts— 7 new validation cases for changeset existencetests/tools/diagnose/pipeline.test.ts— step_id + include_all_step_logs guardtests/registry/registry.test.ts— count/stats paired-filter guardWhy these tests materially reduce regression risk
pipeline_summarizercould enter whole-pipeline mode on a single-step URL — wasteful log fetches and wrong analysis scope.cost_categoryfilter if the paired guard regressed; tests mirror the list contract.Type of Change
Checklist
pnpm testpasses (targeted: dbops, diagnose/pipeline, registry — 235 tests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses