test: lock in schema sync contracts for PR #692 upstream fields - #694
Draft
cursor[bot] wants to merge 3 commits into
Draft
test: lock in schema sync contracts for PR #692 upstream fields#694cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
…teReleaseRepo Add regression tests for upstream fields synced in PR #692: - IACMRemediationAgentInfo.llmConnectorRef (AI remediation step LLM connector) - UpdateReleaseRepoStepInfo.ignoreMissingValues (GitOps release repo step) Covers bundled schema shape and harness_schema path resolution. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
UpdateReleaseRepoStepInfo carries a top-level $ref that inlineRefs replaces, so assert the step node type enum instead; field shape is covered by the bundle contract test. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for upstream schema fields synced in #692 (
chore: auto-sync harness schemas):IACMRemediationAgentInfo.llmConnectorRef— LLM connector reference for IACM remediation agent stepsUpdateReleaseRepoStepInfo.ignoreMissingValues— GitOps update-release-repo step flag (boolean or expression)Risky behavior now covered
pipelineandtemplateschemas retain the new upstream fields after auto-sync; a missing or renamed field will fail CI before agents/tools consume stale shapes.harness_schemapath resolution still findsIACMRemediationAgentInfo(withllmConnectorRef) andUpdateReleaseRepoStepNode(GitOpsUpdateReleaseRepo) for pipeline authoring workflows.Test files added/updated
tests/schemas/schema-bundle-contract.test.ts— asserts field presence and shape in bundled schemastests/tools/harness-schema-tool.test.ts— assertsharness_schemacan resolve the new/related step definitions by bare nameWhy these tests materially reduce regression risk
Auto-sync PRs only change generated schema blobs; without contract tests, upstream field additions can be silently dropped on the next sync or break
harness_schemalookup paths. These tests follow the established pattern from #606 and catch schema drift at the exact integration points agents use.Type of Change
Checklist
pnpm testpasses (targeted: schema bundle + harness_schema tests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses