test: cover PullRequestReview trigger and v1 registry schema sync#681
Draft
cursor[bot] wants to merge 2 commits into
Draft
test: cover PullRequestReview trigger and v1 registry schema sync#681cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Add contract tests for upstream harness-schema changes synced in PR #680: - PullRequestReview GitHub webhook trigger type and github_pr_review_spec - registry field rename (replacing registryRef) in v1 Container definitions Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression contract tests for upstream harness-schema changes synced in PR #680 (
chore: auto-sync harness schemas).Risky behavior now covered
PullRequestReviewwebhook trigger — New trigger type enum value and conditionalif/thenbranch routing togithub_pr_review_spec. A regression would silently drop support for PR review webhooks inharness_schema/harness_createtrigger payloads.github_pr_review_specactions — ValidatesSubmitted,Edited, andDismissedaction enums plusconnectorRef/repoNamefields. Prevents partial or incorrect spec sync.registryfield rename — Upstream renamedregistryRef→registryfor Harness Artifact Registry image references in v1 pipeline/template Container definitions. A stale field name would cause agents to generate invalid v1 pipeline YAML.Test files added/updated
tests/schemas/schema-bundle-contract.test.ts— 3 new contract tests following the existing upstream-sync assertion pattern.Why these tests materially reduce regression risk
Schema sync PRs are auto-generated and touch large data files with no runtime logic changes, making diffs hard to review. These contract tests pin the three user-facing behavioral changes from the latest sync so a future revert, partial merge, or stale bundle would fail CI immediately rather than shipping incorrect schema guidance to MCP clients.
Type of Change
Checklist
pnpm testpasses (focused:tests/schemas/schema-bundle-contract.test.ts— 19 tests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses