Fix failed log misattribution in pipeline summaries#673
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
Contributor
|
@cursor wouldn't it cause an issue when logbasekey is very long? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a correctness bug in the new bulk pipeline-log summarization path. When multiple failed steps shared an identifier across stages,
all_step_logscould attach the first matching stage's log to another step, producing a false execution summary.The failed-log fetch path now retains a map keyed by the canonical
logBaseKey, and bulk result assembly merges each fetched value using that exact key. A regression test covers duplicatedeployidentifiers in separate stages with distinct logs.Type of Change
Checklist
pnpm testpasses (117 files, 2565 tests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpasses (80 tests)pnpm docs:checkpassesCoding Standards (registry-driven MCP model)
Not applicable — this change does not add or modify Harness API coverage or tool registration.