test(registry): extend structural validation to full registry#671
Open
rainhotel wants to merge 2 commits into
Open
test(registry): extend structural validation to full registry#671rainhotel wants to merge 2 commits into
rainhotel wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Extends the registry structural-validation test suite so that universal invariants (paths/params, scope, HTTP methods, extractors, operationPolicy, write-metadata, descriptions) are evaluated against the full Registry (defaults + opt-in toolsets), while keeping default-exposure semantics assertions scoped to the default Registry.
Changes:
- Switch structural invariants to iterate over a single “full registry” instance built via
HARNESS_TOOLSETSadditive selection (covering opt-in toolsets and bothpipeline/pipeline_v1). - Replace prior opt-in-only structural checks with full-registry invariants + targeted regression coverage (including an injected invalid opt-in toolset via
RegistryOptions.additionalToolsets). - Add task tracking notes for Issue #119 work and lessons learned.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/registry/structural-validation.test.ts | Runs universal structural invariants against the full registry; adds regression + exposure-semantics assertions. |
| tasks/todo.md | Records Issue #119 execution plan and verification notes. |
| tasks/lessons.md | Captures a lesson about revalidating historical helpers against current runtime behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Author
|
Hi @thisrohangupta, just checking in — is there anything you'd like me to adjust on this PR, or does it look good to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends universal structural invariants to the full registry, including opt-in toolsets, while keeping default exposure rules scoped to the default registry.
Current main registers both
pipelineandpipeline_v1simultaneously;HARNESS_PIPELINE_VERSIONonly controls the default preference. The tests therefore use one complete Registry rather than duplicating identical V0/V1 variants.Closes #119.
Type of Change
Changes
ToolsetDefinition.optInpipeline, andpipeline_v1are coveredRegistryOptions.additionalToolsetsto exercise the same Registry and validator pathValidation
pnpm standards:check: 77/77pnpm typecheck: passedpnpm build: passed--testTimeout=30000: 2542 passed, 8 skippedThe default
pnpm testcommand still hits the existing 5-second timeout intests/search/manager.test.tsfor the local semantic-search provider. The same failure was reproduced on a cleanorigin/mainworktree, so it is not introduced by this change.Checklist
pnpm testpasses — blocked locally by the clean-main 5-second search timeout described abovepnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checknot required — registry/tool counts are unchangedCoding Standards
This PR changes tests only and does not add or modify Harness API coverage, tool registrations, endpoint policies, extractors, or resource definitions.