Fix CCM recommendation pagination truncation#664
Open
cursor[bot] wants to merge 2 commits into
Open
Conversation
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
thisrohangupta
marked this pull request as ready for review
July 21, 2026 15:35
Contributor
Author
There was a problem hiding this comment.
PR Risk Assessment: Low
Evidence (from diff only)
- 3 files changed (+44 / −2): production fix in
src/registry/toolsets/ccm.ts, regression test intests/registry/registry.test.ts, internal task notes intasks/todo.md. - Production change:
cost_recommendationlistbodyBuildernow derives RESToffset/limitfrom standardpage/sizeinputs (with explicitoffset/limitoverrides preserved). Previously pagination inputs were ignored, so later pages always returned the first 20 results. - Blast radius: isolated to CCM recommendation listing; no shared dispatch, auth, or config changes.
- Operation policy: read-only (
risk: "read",retryPolicy: "safe"). - Tests: focused regression asserting
page: 2, size: 50→offset: 100, limit: 50. - CI: build/test/smoke checks passing.
Decision
- Review required? No (Low risk).
- Reviewers assigned? None.
- Approval: Low risk — would approve, but GitHub blocks approving a PR authored by the same bot account. Human merge/approval still needed for branch protection.
Sent by Cursor Automation: Assign PR reviewers
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
harness_list(resource_type="cost_recommendation")exposed standardpageandsizecontrols, but its REST body builder ignored them and always sentoffset: 0, limit: 20. Requests for later pages therefore returned the first page again, silently preventing callers from retrieving recommendations beyond the first 20.This maps
page/sizeto the endpoint'soffset/limitbody fields while preserving explicit resource-specificoffset/limitoverrides. A focused regression coverspage: 2, size: 50producingoffset: 100, limit: 50.Type of Change
Checklist
pnpm testpasses (117 files, 2554 tests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpasses (10 files, 80 tests)pnpm docs:checkpassesCoding Standards (registry-driven MCP model)
server.registerTool()calls — only a focused existing toolset changeoperationPolicyretainedconsole.log()added