initial config-service onboarding#1608
Open
japoorv wants to merge 35 commits into
Open
Conversation
|
|
Two issues surfaced when smpairgappatch1 deployed config-service via
the umbrella chart:
- the rendered Deployment used `<+artifacts.primary.tag>` as the
image tag. That's a Harness CD pipeline expression — it only
resolves under HelmDeploy, so plain `helm upgrade` in SMP leaves
the literal token in the manifest. The subchart's own
configService.image.repository ("config-service") also wins over
migrate-image-repos.sh's rewrite of the top-level image block.
- kafka TLS user/truststore secrets (kafka-platform-super-admin,
kafka-platform-cluster-ca-cert) are mounted by default; not
present in SMP namespaces, so the pod gets stuck in Init.
Pin the image to the published signed artifact and disable kafka at
the UDP module level so every SMP consumer of this module gets the
right defaults without per-devspace overrides.
Drop dep version so the SMP release helper sees a real diff when bumping to 0.1.130 on the next PL-1234 build, otherwise the helper finds nothing to commit and never pushes the ticket branch to origin.
- Add schema-service as a dep at 0.13.5 (one notch behind latest 0.13.6 so the SMP release helper sees a real diff on next ticket-branch push). - Pin image to harnesssecure/schema-service-signed:0.13.6 and disable kafka via override, mirroring the config-service pattern. - Add docker-repo-map entry so migrate-image-repos.sh rewrites the rendered chart image to harnesssecure/schema-service-signed. Pre-req: secops needs to create harnesssecure/schema-service-signed on docker.io before deployments can pull successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.