DRAFT PR : Testing Big PR - 2500+ files changed

.eslintrc.js

@@ -0,0 +1,108 @@
+/* eslint-disable @typescript-eslint/no-var-requires */
+const { classNameRules } = require('./eslint/rules.js')
+
+module.exports = {
+  root: true,
+  env: {
+    browser: true,
+    es2021: true,
+    node: true
+  },
+  parser: '@typescript-eslint/parser',
+  parserOptions: {
+    ecmaFeatures: {
+      jsx: true
+    },
+    ecmaVersion: 'latest',
+    sourceType: 'module'
+  },
+  extends: [
+    'eslint:recommended',
+    'plugin:import/recommended',
+    'plugin:import/typescript',
+    'plugin:@typescript-eslint/recommended',
+    'plugin:i18next/recommended',
+
+    'plugin:react/recommended',
+    'plugin:react-hooks/recommended',
+    'plugin:jsx-a11y/recommended',
+    'plugin:tailwindcss/recommended',
+
+    'prettier'
+  ],
+  plugins: ['@typescript-eslint', 'tailwindcss', 'react', 'react-hooks', 'import', 'prettier', 'i18next'],
+  settings: {
+    react: {
+      version: 'detect'
+    },
+    'import/resolver': {
+      typescript: true,
+      node: true
+    }
+  },
+  rules: {
+    'tailwindcss/no-contradicting-classname': 'error',
+    'import/no-unresolved': 'off',
+    'react/prop-types': 'off',
+    'react/react-in-jsx-scope': 'off',
+
+    /**
+     * Soon it will be converted to "error"
+     * once all the old variants are removed
+     */
+    'no-restricted-syntax': ['warn', ...classNameRules],
+
+    'jsx-a11y/click-events-have-key-events': 'warn',
+    'jsx-a11y/no-autofocus': 'off',
+    'i18next/no-literal-string': [
+      'warn',
+      {
+        mode: 'jsx-only',
+        'jsx-attributes': {
+          exclude: ['className', 'data-testid', 'id', 'type', 'size', 'name', 'variant', 'style', 'href', 'target']
+        }
+      }
+    ],
+
+    '@typescript-eslint/no-unused-vars': [
+      'error',
+      {
+        argsIgnorePattern: '^_',
+        varsIgnorePattern: '^_',
+        caughtErrorsIgnorePattern: '^_'
+      }
+    ],
+
+    '@typescript-eslint/no-explicit-any': 'warn',
+
+    'tailwindcss/no-custom-classname': 'off'
+  },
+  ignorePatterns: ['**/dist/**'],
+  overrides: [
+    {
+      files: [
+        'packages/ui/**/*.{ts,tsx}',
+        'packages/filters/**/*.{ts,tsx}',
+        'packages/forms/**/*.{ts,tsx}',
+        'packages/pipeline-graph/**/*.{ts,tsx}',
+        'packages/core-design-system/**/*.{ts,tsx}',
+        'packages/yaml-editor/**/*.{ts,tsx}'
+      ],
+      rules: {
+        'no-restricted-imports': 'off',
+        '@typescript-eslint/no-restricted-imports': [
+          'error',
+          {
+            paths: [
+              {
+                name: 'react-router-dom',
+                message: 'Please use only type imports from react-router-dom.',
+                allowTypeImports: true
+              }
+            ]
+          }
+        ]
+      }
+    }
+  ]
+}

.github/workflows/build-and-deploy-storybook.yml

@@ -1,6 +1,5 @@
 name: PR Checks
 on:
-  push:
   pull_request_target:
     types:
       - opened
@@ -10,6 +9,21 @@ on:
       - main
 
 jobs:
+  CheckCleanGitTree:
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+      - uses: pnpm/action-setup@v4
+      - run: pnpm deps
+      - run: pnpm build
+      - name: Check for uncommitted changes
+        run: |
+          # Show only the names of changed files
+          echo "Changed files:"
+          git diff --name-only HEAD --exit-code || (echo "Error: There are uncommitted changes in the working tree. Please commit or revert these changes." && exit 1)
+
   Lint:
     runs-on: ubuntu-22.04
     steps:
@@ -52,3 +66,14 @@ jobs:
       - run: pnpm deps
       - run: pnpm build
       - run: pnpm test
+
+  Build_Microfrontend:
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+      - uses: pnpm/action-setup@v4
+      - run: pnpm install
+      - run: pnpm build
+      - run: pnpm -r -F ./apps/gitness build:webpack

.github/workflows/publish.yml

@@ -0,0 +1,26 @@
+name: Publish Packages to npm
+
+on: workflow_dispatch
+
+jobs:
+  publish:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+
+      - name: Install and build dependencies
+        run: |
+          pnpm install
+          pnpm build
+
+      - name: Authenticate to npm
+        run: |
+          echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_PUBLISH_TOKEN }}" > ~/.npmrc
+
+      - name: Publish packages to npm
+        run: pnpm publish:all

.vscode/settings.json

@@ -9,5 +9,8 @@
   "[ignore]": {
     "editor.defaultFormatter": "foxundermoon.shell-format"
   },
-  "prettier.trailingComma": "none"
+  "prettier.trailingComma": "none",
+  "workbench.editorAssociations": {
+    "*.svg": "default"
+  }
 }

CODEOWNERS

@@ -1,4 +1,23 @@
-packages/canary @knagurski
-packages/views @knagurski
-packages/ui @knagurski
-apps/design-system @knagurski
+# Global configs
+.github/ abhinav.rastogi@harness.io kevin.nagurski@harness.io vardan.bansal@harness.io
+.eslintrc.js abhinav.rastogi@harness.io kevin.nagurski@harness.io vardan.bansal@harness.io
+.prettierrc.yml abhinav.rastogi@harness.io kevin.nagurski@harness.io vardan.bansal@harness.io
+
+# Common ownership for shared config files
+/packages/*/package.json abhinav.rastogi@harness.io kevin.nagurski@harness.io vardan.bansal@harness.io
+/apps/*/package.json abhinav.rastogi@harness.io kevin.nagurski@harness.io vardan.bansal@harness.io
+/packages/*/vite.config.ts abhinav.rastogi@harness.io kevin.nagurski@harness.io vardan.bansal@harness.io
+/apps/*/vite.config.ts abhinav.rastogi@harness.io kevin.nagurski@harness.io vardan.bansal@harness.io
+
+# Apps
+/apps/gitness/* abhinav.rastogi@harness.io vardan.bansal@harness.io
+/apps/portal/* kevin.nagurski@harness.io pranesh.g@harness.io abhinav.rastogi@harness.io vardan.bansal@harness.io
+
+# Packages with shared ownership
+/packages/ui/* abhinav.rastogi@harness.io kevin.nagurski@harness.io vardan.bansal@harness.io pranesh.g@harness.io
+
+# Packages with individual owners
+/packages/forms/* srdjan.arsic@harness.io
+/packages/unified-pipeline/* srdjan.arsic@harness.io
+/packages/yaml-editor/* srdjan.arsic@harness.io
+/packages/core-design-system/* pranesh.g@harness.io

Dockerfile

@@ -1,4 +1,4 @@
-FROM node:20-slim AS base
+FROM us-west1-docker.pkg.dev/gar-setup/docker/node:20-slim AS base
 ENV PNPM_HOME="/pnpm"
 ENV PATH="$PNPM_HOME:$PATH"
 # install pnpm
@@ -16,7 +16,7 @@ RUN --mount=type=cache,id=pnpm,target=/pnpm/store pnpm install --frozen-lockfile
 # build all the packages and apps except portal and design-system
 RUN pnpm --filter \!portal --filter \!design-system run build
 
-FROM alpine:3.21 AS final
+FROM us-west1-docker.pkg.dev/gar-setup/docker/alpine:3.21 AS final
 COPY --from=build /canary/apps/gitness/dist /canary-dist
 WORKDIR /canary-dist
 

Dockerfile.mfe

@@ -1,4 +1,4 @@
-FROM node:20-slim AS base
+FROM us-west1-docker.pkg.dev/gar-setup/docker/node:20-slim AS base
 ENV PNPM_HOME="/pnpm"
 ENV PATH="$PNPM_HOME:$PATH"
 # install pnpm
@@ -20,7 +20,7 @@ WORKDIR /canary/apps/gitness
 RUN rm -rf dist
 RUN pnpm run build:webpack
 
-FROM alpine:3.21 AS final
+FROM us-west1-docker.pkg.dev/gar-setup/docker/alpine:3.21 AS final
 COPY --from=build /canary/apps/gitness/dist /canary-dist
 WORKDIR /canary-dist
 

README.md

@@ -10,7 +10,6 @@ Welcome to the Harness Canary monorepo! This repository contains multiple projec
 # Projects
 
 - [@harnessio/canary](./packages/canary/) - Harness Canary UI components library built on top of [Radix UI](https://www.radix-ui.com/) and [ShadCN UI](https://ui.shadcn.com/).
-- [@harnessio/views](./packages/views/) - Harness Unified UI View Fragments.
 
 # Getting Started
 

apps/design-system/package.json

@@ -13,9 +13,11 @@
     "typecheck": "tsc -b"
   },
   "dependencies": {
+    "@harnessio/forms": "workspace:*",
     "@harnessio/pipeline-graph": "workspace:*",
     "@harnessio/ui": "workspace:*",
     "@harnessio/yaml-editor": "workspace:*",
+    "@tanstack/react-table": "^8.21.3",
     "@types/lodash-es": "^4.17.12",
     "clsx": "^2.1.1",
     "lodash-es": "^4.17.21",

apps/design-system/src/App.tsx

@@ -1,44 +1,31 @@
 import { FC } from 'react'
-import {
-  createBrowserRouter,
-  Link,
-  Navigate,
-  NavLink,
-  Outlet,
-  RouterProvider,
-  useMatches,
-  useSearchParams
-} from 'react-router-dom'
+import { createBrowserRouter, Navigate, RouterProvider } from 'react-router-dom'
 
-import ComponentPage from '@/pages/component-page'
 import ViewPreview from '@/pages/view-preview/view-preview'
-import DocsLayout from '@components/docs-layout/docs-layout'
 import { useThemeStore } from '@utils/theme-utils'
 
-import { RouterContextProvider, ThemeProvider } from '@harnessio/ui/context'
+import { ThemeProvider, TranslationProvider } from '@harnessio/ui/context'
+
+import AppRouterProvider from './AppRouterProvider'
 
 const router = createBrowserRouter([
-  { path: '/view-preview/*', element: <ViewPreview /> },
-  { path: '/docs/*', element: <DocsLayout />, children: [{ path: 'components/*', element: <ComponentPage /> }] },
-  { path: '/*', element: <Navigate to="/docs" /> }
+  {
+    element: <AppRouterProvider />,
+    children: [
+      { path: '/view-preview/*', element: <ViewPreview /> },
+      { path: '/*', element: <Navigate to="/view-preview" /> }
+    ]
+  }
 ])
 
 const App: FC = () => {
   const themeStore = useThemeStore()
 
   return (
     <ThemeProvider {...themeStore}>
-      <RouterContextProvider
-        Link={Link}
-        NavLink={NavLink}
-        Outlet={Outlet}
-        navigate={router.navigate}
-        location={{ ...window.location, state: {}, key: '' }}
-        useSearchParams={useSearchParams}
-        useMatches={useMatches}
-      >
+      <TranslationProvider>
         <RouterProvider router={router} />
-      </RouterContextProvider>
+      </TranslationProvider>
     </ThemeProvider>
   )
 }