fix: allow allowUnderscore on string().email() - #3131
Open
Hashim1999164 wants to merge 1 commit into
Open
Conversation
email() documented and typed allowUnderscore but rejected it in assertOptions, unlike string().domain(). Accept the option so it reaches @hapi/address validation. Closes hapijs#2972
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
string().email()documented and typedallowUnderscore, andaddressOptionsalready forwards it to@hapi/address, butassertOptionsrejected the key (unlikestring().domain()).allowUnderscorein the email options allowlist and add regression coverage for underscored domains.Closes #2972
Test plan
npx lab test/types/string.js -g emailJoi.string().email({ allowUnderscore: true })no longer throws unknown keyuser@_abc.example.comvalidate only when the option is set