fix: ignore internal references when ordering object keys - #3129
Open
xianjianlf2 wants to merge 1 commit into
Open
fix: ignore internal references when ordering object keys#3129xianjianlf2 wants to merge 1 commit into
xianjianlf2 wants to merge 1 commit into
Conversation
When an object key holds a nested object whose value references a sibling key that shares a name with an ancestor key, the reference propagated up as a root reference of the outer key, making that key depend on itself and throwing "Item cannot come after itself" during key ordering. Skip references that a child object resolves internally (i.e. that match one of the child's own keys) when computing the topological ordering, while still surfacing genuine cross-object circular dependencies. Closes hapijs#2877
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an object key holds a nested object whose value references a sibling key that shares a name with an ancestor key, the reference propagated up as a root reference of the outer key. This made that key depend on itself and threw
"Item cannot come after itself"during key ordering.For example, an outer
commandkey containing a nestedcommandkey (referenced by a siblingparamsvia.conditional('command', ...)) would fail to build.Fix
When computing the topological ordering of object keys, skip references that a child object resolves internally (i.e. references that match one of the child's own keys). Genuine cross-object circular dependencies are still surfaced.
Testing
Added a test in
test/types/object.jscovering an object whose nested key references a duplicated sibling key name, verifying the schema builds and validates correctly (including theconditional/switchbranches).Closes #2877