Skip to content

Prepare for Jackson-Tools-3 Uplift. (JT3)#8108

Merged
jamesagnew merged 2 commits into
hapifhir:masterfrom
granadacoder:feature/prepare-for-jackson-tools-3-uplift-1
Jun 21, 2026
Merged

Prepare for Jackson-Tools-3 Uplift. (JT3)#8108
jamesagnew merged 2 commits into
hapifhir:masterfrom
granadacoder:feature/prepare-for-jackson-tools-3-uplift-1

Conversation

@granadacoder

@granadacoder granadacoder commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

This PR is NOT the (a) Jackson-Tools-3 Uplift.

This PR is adding more unit-tests on java-classes that will (eventually in a future PR) be substantially effected by the JT3 uplift.

This will help ensure that the JT3 uplift (later) does not break existing functionality.

4 new unit-test-only classes. And new tests in an existing unit-test class.

The unit-tests themselves were largely written by github-copilot. (I don't remember the model).
But the prompt was "Add covering unit-tests and pay attention to future Jackson-Tools-3 upgrade edge cases".

This PR is NOT the Jackson-Tools-3 Uplift.

This PR is adding more unit-tests on java-classes that will (eventually in a future PR) be substantially effected by the JT3 uplift.
@tadgh

tadgh commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Formatting check succeeded!

@granadacoder

granadacoder commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

Bread Crumb 1:

https://github.com/hapifhir/hapi-fhir/blob/master/hapi-fhir-base/src/main/java/ca/uhn/fhir/parser/json/jackson/JacksonWriter.java#L45L62

This will be different in the future JT3 change.

Jackson-Tool-3 has changed to "immutable" "builder" approach.

So many "setters" .. for configuration are gone. And have to be a part of the pre builder-"build" command.

@granadacoder

Copy link
Copy Markdown
Contributor Author

Bread Crumb 2 :

https://github.com/hapifhir/hapi-fhir/blob/master/hapi-fhir-base/src/main/java/ca/uhn/fhir/parser/json/jackson/JacksonStructure.java#L409L424

Same situation. JT3 will not be "setters". It will be the builder pattern.

@granadacoder

Copy link
Copy Markdown
Contributor Author

Bread Crumb 3 :

https://github.com/hapifhir/hapi-fhir/blob/master/hapi-fhir-base/src/main/java/ca/uhn/fhir/util/JsonUtil.java#L60L81

Same situation. No configuration-setters in JT3. Builder pattern will be used for immutability.

…remove (deprecated/abandoned) : com.github.fge.jsonpatch
@granadacoder

Copy link
Copy Markdown
Contributor Author

@jamesagnew jamesagnew left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@jamesagnew
jamesagnew merged commit 69d7f92 into hapifhir:master Jun 21, 2026
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants