Fix Windows (MSVC) build: pwsh compatibility and import lib name collision - #197
Merged
Merged
Conversation
collision Signed-off-by: 稲路針 <i768ry.g@gmail.com>
Owner
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Windows環境でMSVCを使用してビルドした際に発生していた2つの不具合を修正しました。
修正内容
(pwshとbashで環境変数の指定構文が異なるため、pwsh環境でのビルド失敗を回避)
MSVCが自動生成するlibファイルとlibmruby_staticのファイル名衝突を解消