Split post modules along feature boundaries

ARCHITECTURE.md

@@ -23,3 +23,41 @@ introduced.
 The package boundary tests in *test/package-boundaries.test.ts* compare core
 package manifests with their production module graphs and reject workspace
 dependency cycles.
+
+
+Post feature boundaries
+-----------------------
+
+The models package exposes post behavior through focused public subpaths.  New
+code should import the narrowest applicable module instead of the compatibility
+facade at *@hackerspub/models/post*:
+
+| Subpath                              | Responsibility                                      |
+| ------------------------------------ | --------------------------------------------------- |
+| *@hackerspub/models/post/core*       | Post object guards and persisted post lookup        |
+| *@hackerspub/models/post/remote*     | Remote ActivityPub ingestion and deletion           |
+| *@hackerspub/models/post/source*     | Local article, note, and question synchronization   |
+| *@hackerspub/models/post/visibility* | Visibility, moderation, and interaction policies    |
+| *@hackerspub/models/post/sharing*    | Local share and unshare operations                  |
+| *@hackerspub/models/post/engagement* | Reply, share, and quote counters and quote revoking |
+| *@hackerspub/models/post/lifecycle*  | Local post deletion                                 |
+| *@hackerspub/models/link-preview*    | Link scraping, persistence, and repair              |
+
+*models/post.ts* remains an explicit re-export facade for existing consumers.
+It contains no post behavior.  Article source rendering helpers live in
+*models/article-source.ts* so local post synchronization does not form a cycle
+with the article model.
+
+The GraphQL post schema follows the same registration boundaries under
+*graphql/post/*.  *core.ts* owns the `Post` interface, shared fields, media, and
+link types; *article.ts* owns article and draft types; *note.ts* owns note and
+question types; and *mutations.ts* owns post mutations and queries.  Actor post
+fields and `Account.articleDrafts` are registered by *actor-fields.ts* and
+*article-fields.ts* from the GraphQL composition root after their base types are
+available.  This avoids `actor` or `account` importing the post facade.
+
+*graphql/post.ts* is a compatibility facade that preserves the historical
+public type references.  Adding a post feature means registering it in a
+focused module and importing that registration from *graphql/mod.ts*; schema
+generation must remain deterministic and must not change merely because a
+registration moved between modules.

federation/collections.ts

@@ -8,7 +8,7 @@ import { removeHeaderAnchorLinks } from "@hackerspub/models/html";
 import {
   getSanctionHiddenActorFilter,
   isActorSanctionHidden,
-} from "@hackerspub/models/post";
+} from "@hackerspub/models/post/visibility";
 import {
   actorTable,
   followingTable,

federation/inbox/quote.ts

@@ -17,15 +17,14 @@ import {
 } from "@hackerspub/models/actor";
 import type { ContextData } from "@hackerspub/models/context";
 import { toApplicationContext } from "../context.ts";
+import { isPostObject, type PostObject } from "@hackerspub/models/post/core";
+import { updateQuotesCount } from "@hackerspub/models/post/engagement";
+import { persistPost } from "@hackerspub/models/post/remote";
 import {
   canActorQuotePost,
   canActorRequestQuotePost,
   getOriginalPostId,
-  isPostObject,
-  persistPost,
-  type PostObject,
-  updateQuotesCount,
-} from "@hackerspub/models/post";
+} from "@hackerspub/models/post/visibility";
 import {
   type Actor,
   type Blocking,

federation/inbox/subscribe.ts

@@ -31,14 +31,14 @@ import {
 import {
   deletePersistedPost,
   deleteSharedPost,
-  isPostObject,
   PERSIST_POST_OVERALL_BUDGET_MS,
   persistPost,
   persistSharedPost,
   REMOTE_FETCH_TIMEOUT_MS,
-  updateRepliesCount,
   withDocumentLoaderTimeout,
-} from "@hackerspub/models/post";
+} from "@hackerspub/models/post/remote";
+import { isPostObject } from "@hackerspub/models/post/core";
+import { updateRepliesCount } from "@hackerspub/models/post/engagement";
 import { persistPollVoteResult } from "@hackerspub/models/poll";
 import {
   deleteReaction,

federation/inbox/update.ts

@@ -2,7 +2,7 @@ import type { InboxContext } from "@fedify/fedify";
 import { isActor, type Update } from "@fedify/vocab";
 import { isCachedActorFederationBlocked } from "@hackerspub/models/actor";
 import type { ContextData } from "@hackerspub/models/context";
-import { isPostObject } from "@hackerspub/models/post";
+import { isPostObject } from "@hackerspub/models/post/core";
 import { getLogger } from "@logtape/logtape";
 import { onActorUpdated } from "./actor.ts";
 import { onPostUpdated } from "./subscribe.ts";

federation/objects.ts

@@ -21,7 +21,7 @@ import {
   isActorSanctionHidden,
   isPostVisibleTo,
   normalizeQuotePolicyForVisibility,
-} from "@hackerspub/models/post";
+} from "@hackerspub/models/post/visibility";
 import type {
   Account,
   Actor,

graphql/account.ts

@@ -48,7 +48,6 @@ import { InvitationLink } from "./invitation-link.ts";
 import { lookupActorByUrl, parseHttpUrl } from "./lookup.ts";
 import { Notification } from "./notification.ts";
 import { putProfileOgImage } from "./og.ts";
-import { ArticleDraft } from "./post.ts";
 import {
   fromPostVisibility,
   PostVisibility,
@@ -895,24 +894,6 @@ builder.drizzleObjectField(Account, "invitees", (t) =>
     },
   ));
 
-builder.drizzleObjectField(
-  Account,
-  "articleDrafts",
-  (t) =>
-    t.relatedConnection("articleDrafts", {
-      type: ArticleDraft,
-      description:
-        "Unpublished article drafts belonging to this account, most " +
-        "recently updated first. Only visible to the account holder.",
-      authScopes: (parent) => ({
-        selfAccount: "id" in parent ? parent.id : undefined,
-      }),
-      query: () => ({
-        orderBy: { updated: "desc" },
-      }),
-    }),
-);
-
 // Per-request batching loader for Account.postCount and
 // Account.lastPostPublished.  Without this, requesting these fields on a
 // 50-row connection would fan out to 100 separate aggregate queries.