feat: rename KServe Inference configuration to use RuntimeImage instead of Runtime - #621
Open
RK181 wants to merge 1 commit into
Open
feat: rename KServe Inference configuration to use RuntimeImage instead of Runtime#621RK181 wants to merge 1 commit into
RK181 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the handling of KServe inference runtimes by renaming the
runtimefield toruntime_imagethroughout the codebase and documentation. This change clarifies the field's purpose and usage, ensuring consistency and better alignment with KServe's terminology. The documentation and validation logic are also updated to reflect this change.API and Field Renaming:
runtimefield toruntime_imagein theKserveInferencestruct, updating all references, comments, and JSON tags accordingly to clarify that this field is for specifying a custom KServe runtime image.runtime_imageinstead ofruntime, ensuring correct behavior when comparing or updating KServe inference configurations. [1] [2]Documentation Updates:
docs/fdl.mddocumentation to replace references to theruntimefield withruntime_image, providing clearer guidance on when and why to use this field. The documentation now also explains the relationship between model formats and runtimes.Spec Generation Logic:
runtime_imagefield when setting the runtime in the model spec. [1] [2]Test Updates:
runtime_imageinstead ofruntimewhen verifying that runtime changes are correctly detected as errors.