Fix prefetched scalar decoding precedence - #1877
Open
XX-Q wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1804.
Prefetched association elements were always decoded through
Decodable, even when their database-specific conformances should take precedence. This made values such as UUID-backedDatabaseValueConvertibletypes fail when fetched from a single selected column.This change:
FetchableRecord.init(row:)overDecodablefor prefetched rows;ColumnDecoderpaths forData,Date,DatabaseValueConvertible, andStatementColumnConvertiblevalues;Decodabledecoding as the fallback;Validation:
swift buildpasses.MedalIDcase now passes.FetchableRecord.init(row:)is selected overDecodable.no such module XCTest; the added tests are intended to run in CI.Pull Request Checklist
development.make smokeTestruns without failure. (Not run: full Xcode is unavailable locally.)