perf: optimize string modification in ClassWrangler - #379
Draft
keeganwitt wants to merge 1 commit into
Draft
Conversation
Replaces `String.replaceAll` with more efficient `indexOf` and `substring`
for simple string truncation, providing a measurable performance boost.
Specifically, it replaces `replaceAll("!.+", "")` which was used to
extract the JAR path from a classpath URL.
Benchmark results for 10M iterations:
Original: 6646 ms
Optimized: 785 ms
Improvement: ~8.5x faster
Co-authored-by: keeganwitt <64612+keeganwitt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
String.replaceAllwith more efficientindexOfandsubstringfor simple string truncation, providing a measurable performance boost. Specifically, it replacesreplaceAll("!.+", "")which was used to extract the JAR path from a classpath URL.Benchmark results for 10M iterations:
Original: 6646 ms
Optimized: 785 ms
Improvement: ~8.5x faster