Skip to content

Fix: do not compute severity for tasks without a report #3070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheBeast85 wants to merge 1 commit into
base: main
Choose a base branch
from
+40 −20
Open

Fix: do not compute severity for tasks without a report #3070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 40 additions & 20 deletions src/manage_pg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1452,11 +1452,16 @@ manage_create_sql_functions ()
" FROM tasks WHERE id = $1)"
" THEN CAST (NULL AS double precision)"
" ELSE"
" (SELECT report_severity ((SELECT id FROM reports"
" WHERE task = $1"
" AND scan_run_status = %u"
" ORDER BY creation_time DESC"
" LIMIT 1 OFFSET 0), $2, $3))"
/* Only look up the severity when the task has a report. Calling
* report_severity with NULL returns NULL as well, but it costs a
* full evaluation of the severity query for every task that never
* ran, which dominates aggregates over many tasks. */
" (SELECT report_severity (last_report.id, $2, $3)"
" FROM (SELECT id FROM reports"
" WHERE task = $1"
" AND scan_run_status = %u"
" ORDER BY creation_time DESC"
" LIMIT 1 OFFSET 0) AS last_report)"
" END;"
"$$ LANGUAGE SQL;",
TASK_STATUS_DONE);
Expand All @@ -1477,11 +1482,16 @@ manage_create_sql_functions ()
" FROM tasks WHERE id = $1)"
" THEN CAST (NULL AS double precision)"
" ELSE"
" (SELECT report_severity ((SELECT id FROM reports"
" WHERE task = $1"
" AND scan_run_status = %u"
" ORDER BY creation_time DESC"
" LIMIT 1 OFFSET 0), $2, $3))"
/* Only look up the severity when the task has a report. Calling
* report_severity with NULL returns NULL as well, but it costs a
* full evaluation of the severity query for every task that never
* ran, which dominates aggregates over many tasks. */
" (SELECT report_severity (last_report.id, $2, $3)"
" FROM (SELECT id FROM reports"
" WHERE task = $1"
" AND scan_run_status = %u"
" ORDER BY creation_time DESC"
" LIMIT 1 OFFSET 0) AS last_report)"
" END;"
"$$ LANGUAGE SQL;",
TASK_STATUS_DONE);
Expand All @@ -1499,11 +1509,16 @@ manage_create_sql_functions ()
" FROM tasks WHERE id = $1)"
" THEN CAST (NULL AS double precision)"
" ELSE"
" (SELECT report_severity ((SELECT id FROM reports"
" WHERE task = $1"
" AND scan_run_status = %u"
" ORDER BY creation_time DESC"
" LIMIT 1 OFFSET 0), $2, $3))"
/* Only look up the severity when the task has a report. Calling
* report_severity with NULL returns NULL as well, but it costs a
* full evaluation of the severity query for every task that never
* ran, which dominates aggregates over many tasks. */
" (SELECT report_severity (last_report.id, $2, $3)"
" FROM (SELECT id FROM reports"
" WHERE task = $1"
" AND scan_run_status = %u"
" ORDER BY creation_time DESC"
" LIMIT 1 OFFSET 0) AS last_report)"
" END;"
"$$ LANGUAGE SQL;",
TASK_STATUS_DONE);
Expand All @@ -1521,11 +1536,16 @@ manage_create_sql_functions ()
" FROM tasks WHERE id = $1)"
" THEN CAST (NULL AS double precision)"
" ELSE"
" (SELECT report_severity ((SELECT id FROM reports"
" WHERE task = $1"
" AND scan_run_status = %u"
" ORDER BY date DESC"
" LIMIT 1 OFFSET 0), $2, $3))"
/* Only look up the severity when the task has a report. Calling
* report_severity with NULL returns NULL as well, but it costs a
* full evaluation of the severity query for every task that never
* ran, which dominates aggregates over many tasks. */
" (SELECT report_severity (last_report.id, $2, $3)"
" FROM (SELECT id FROM reports"
" WHERE task = $1"
" AND scan_run_status = %u"
" ORDER BY date DESC"
" LIMIT 1 OFFSET 0) AS last_report)"
" END;"
"$$ LANGUAGE SQL;",
TASK_STATUS_DONE);
Expand Down