More detailed error handling for function "stop_task (...)". - #3009
Open
jhelmold wants to merge 1 commit into
Open
More detailed error handling for function "stop_task (...)".#3009jhelmold wants to merge 1 commit into
jhelmold wants to merge 1 commit into
Conversation
jhelmold
marked this pull request as ready for review
July 6, 2026 12:43
| if (scanner_type (task_scanner (task)) == SCANNER_TYPE_OPENVAS | ||
| || scanner_type (task_scanner (task)) == SCANNER_TYPE_OSP_SENSOR) | ||
| return stop_osp_task (task); | ||
| return stop_osp_task (task) * 10; |
Member
There was a problem hiding this comment.
I think we have enough return codes for stop_task where using an enum and a small helper function that maps the return values from stop_osp_task would make things more readable.
Comment on lines
+869
to
+870
| if (filter_column == NULL) | ||
| return NULL; |
Member
There was a problem hiding this comment.
This appears to be unrelated to the error handler improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The returned error codes of the function "stop_task (...)" are handled in more detail now.
Why
This is part of a bug-fix.
References
GEA-1642