Skip to content

Clear password from memory #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janlucasschwoerer-greenbone wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clear password from memory #2743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/gmp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,9 @@ typedef struct
static void
create_credential_data_reset (create_credential_data_t *data)
{
memset (data->password, 0, strlen (data->password));
memset (data->privacy_password, 0, strlen (data->privacy_password));

free (data->allow_insecure);
free (data->certificate);
free (data->comment);
Expand Down Expand Up @@ -1211,6 +1214,8 @@ typedef struct
static void
create_user_data_reset (create_user_data_t * data)
{
memset (data->password, 0, strlen (data->password));

g_free (data->copy);
array_free (data->groups);
g_free (data->name);
Expand Down Expand Up @@ -2644,6 +2649,9 @@ typedef struct
static void
modify_credential_data_reset (modify_credential_data_t *data)
{
memset (data->password, 0, strlen (data->password));
memset (data->privacy_password, 0, strlen (data->password));

@mattmundell mattmundell Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strlen should be on same field.


free (data->allow_insecure);
free (data->auth_algorithm);
free (data->certificate);
Expand Down Expand Up @@ -3220,6 +3228,8 @@ typedef struct
static void
modify_user_data_reset (modify_user_data_t * data)
{
memset (data->password, 0, strlen (data->password));

array_free (data->groups);
g_free (data->name);
g_free (data->new_name);
Expand Down Expand Up @@ -12866,7 +12876,8 @@ handle_get_credentials (gmp_parser_t *gmp_parser, GError **error)
SEND_GET_START("credential");
while (1)
{
const char *login, *type, *cert, *private_key, *password, *public_key;
char *cert, *private_key, *password;
const char *login, *type, *public_key;
gchar *formats_xml;

ret = get_next (&credentials, &get_credentials_data->get,
Expand Down Expand Up @@ -13193,6 +13204,10 @@ handle_get_credentials (gmp_parser_t *gmp_parser, GError **error)
#endif
SEND_TO_CLIENT_OR_FAIL ("</credential>");
count++;

memset (cert, 0, strlen (cert));
memset (private_key, 0, strlen (private_key));
memset (password, 0, strlen (password));
}

cleanup_iterator (&credentials);
Expand Down
32 changes: 32 additions & 0 deletions src/manage_alerts.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2033,6 +2033,8 @@ send_to_sourcefire (const char *ip, const char *port, const char *pkcs12_64,

if (!gvm_file_is_readable (script))
{
memset (clean_password, 0, strlen (clean_password));

g_free (report_file);
g_free (pkcs12_file);
g_free (clean_password);
Expand All @@ -2054,6 +2056,9 @@ send_to_sourcefire (const char *ip, const char *port, const char *pkcs12_64,
g_warning ("%s: Failed to getcwd: %s",
__func__,
strerror (errno));

memset (clean_password, 0, strlen (clean_password));

g_free (report_file);
g_free (pkcs12_file);
g_free (clean_password);
Expand All @@ -2068,6 +2073,9 @@ send_to_sourcefire (const char *ip, const char *port, const char *pkcs12_64,
g_warning ("%s: Failed to chdir: %s",
__func__,
strerror (errno));

memset (clean_password, 0, strlen (clean_password));

g_free (report_file);
g_free (pkcs12_file);
g_free (clean_password);
Expand All @@ -2091,6 +2099,10 @@ send_to_sourcefire (const char *ip, const char *port, const char *pkcs12_64,
pkcs12_file,
report_file,
clean_password);


memset (clean_password, 0, strlen (clean_password));

g_free (script);
g_free (clean_ip);
g_free (clean_port);
Expand Down Expand Up @@ -2423,6 +2435,9 @@ send_to_verinice (const char *url, const char *username, const char *password,
clean_url,
clean_username,
archive_file);

memset (clean_password, 0, strlen (clean_password));

g_free (script);
g_free (clean_url);
g_free (clean_username);
Expand Down Expand Up @@ -4402,6 +4417,9 @@ trigger_to_vfire (alert_t alert, task_t task, report_t report, event_t event,
get_data_reset (alert_filter_get);
g_free (alert_filter_get);
}

memset (password, 0, strlen (password));

@mattmundell mattmundell Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

password technically can be NULL, from credential_encrypted_value


free (base_url);
free (session_type);
free (client_id);
Expand Down Expand Up @@ -4938,6 +4956,8 @@ trigger (alert_t alert, task_t task, report_t report, event_t event,
message, strlen (message),
script_message);

memset (password, 0, strlen (password));

g_free (message);
free (private_key);
free (password);
Expand Down Expand Up @@ -5005,6 +5025,8 @@ trigger (alert_t alert, task_t task, report_t report, event_t event,
report_content, content_length,
script_message);

memset (password, 0, strlen (password));

free (private_key);
free (password);
free (username);
Expand Down Expand Up @@ -5215,6 +5237,8 @@ trigger (alert_t alert, task_t task, report_t report, event_t event,
max_protocol, report_content, content_length,
script_message);

memset (password, 0, strlen (password));

g_free (username);
g_free (password);
free (credential_id);
Expand Down Expand Up @@ -5377,6 +5401,8 @@ trigger (alert_t alert, task_t task, report_t report, event_t event,
ret = send_to_sourcefire (ip, port, pkcs12, pkcs12_password,
report_content);

memset (pkcs12_password, 0, strlen (pkcs12_password));

free (ip);
g_free (port);
free (pkcs12);
Expand Down Expand Up @@ -5486,6 +5512,8 @@ trigger (alert_t alert, task_t task, report_t report, event_t event,
g_free (extension);
if (ret)
{
memset (password, 0, strlen (password));

g_free (username);
g_free (password);
g_free (hostname);
Expand All @@ -5499,6 +5527,8 @@ trigger (alert_t alert, task_t task, report_t report, event_t event,
certificate, tls_cert_workaround,
script_message);

memset (password, 0, strlen (password));

g_free (username);
g_free (password);
g_free (hostname);
Expand Down Expand Up @@ -5577,6 +5607,8 @@ trigger (alert_t alert, task_t task, report_t report, event_t event,
ret = send_to_verinice (url, username, password, report_content,
content_length);

memset (password, 0, strlen (password));

free (url);
g_free (username);
g_free (password);
Expand Down
12 changes: 11 additions & 1 deletion src/manage_openvas.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ set_auth_data_ssh_from_credential_store (iterator_t *iter,
= credential_iterator_host_identifier (iter);

if (cyberark_login_password_credential_data (cred_store_uuid,
vault_id,
vault_id,gm

@timopollmeier timopollmeier Jan 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vault_id,gm
vault_id,

host_identifier,
&login,
&password))
Expand Down Expand Up @@ -307,6 +307,8 @@ set_auth_data_ssh_from_credential_store (iterator_t *iter,
password);
}

memset (password, 0, strlen (password));

g_free (login);
g_free (password);
return 0;
Expand Down Expand Up @@ -390,6 +392,8 @@ set_auth_data_up_from_credential_store (iterator_t *iter,
osp_credential_set_auth_data (osp_credential, "username", login);
osp_credential_set_auth_data (osp_credential, "password", password);

memset (password, 0, strlen (password));

g_free (login);
g_free (password);
return 0;
Expand Down Expand Up @@ -440,6 +444,9 @@ set_auth_data_snmp_from_credential_store (iterator_t *iter,
g_debug ("%s: Error retrieving SNMP privacy password from"
" CyberArk credential store '%s'.",
__func__, cred_store_uuid);

password (password, 0, strlen (password));

@mattmundell mattmundell Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean memset?


g_free (login);
g_free (password);
g_free (privacy_password);
Expand All @@ -451,6 +458,9 @@ set_auth_data_snmp_from_credential_store (iterator_t *iter,
osp_credential_set_auth_data (osp_credential, "privacy_password",
privacy_password);

memset(password, 0, strlen (password));
memset(privacy_password, 0, strlen (privacy_password));

g_free (login);
g_free (password);
g_free (privacy_password);
Expand Down
Loading