Allow to upload encrypted private keys for client cert credentials - #5549
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Allow to display a tooltip for further information about a password field.
…tials There are two kinds of private keys for client certificate credentials. Encrypted and unencrypted. Only the encrypted keys need a passphrase to be able to decrypted them. Therefore change the dialog to allow uploading both private key formats and only to enable the passphrase field for encrypted private keys.
bjoernricks
force-pushed
the
encrypted-private-key
branch
from
August 21, 2026 12:31
3200f7a to
e2f6d91
Compare
bjoernricks
marked this pull request as ready for review
August 21, 2026 12:32
greenbonebot
enabled auto-merge (rebase)
August 21, 2026 12:32
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5549 +/- ##
==========================================
+ Coverage 84.22% 84.25% +0.03%
==========================================
Files 1294 1294
Lines 33807 33817 +10
Branches 10079 10117 +38
==========================================
+ Hits 28473 28494 +21
+ Misses 4785 4781 -4
+ Partials 549 542 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
daniele-mng
reviewed
Aug 24, 2026
daniele-mng
reviewed
Aug 24, 2026
Co-authored-by: Daniele Mangiagli <daniele.mangiagli@greenbone.net>
daniele-mng
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allow to upload encrypted private keys for client cert credentials
Why
There are two kinds of private keys for client certificate credentials. Encrypted and unencrypted. Only the encrypted keys need a passphrase to be able to decrypted them. Therefore change the dialog to allow uploading both private key formats and only to enable the passphrase field for encrypted private keys.
References
Requires greenbone/gsad#445 for unencrypted private keys in client certificate credentials.
https://jira.greenbone.net/browse/GEA-1983
Checklist