fix: clarify safe/approved breaking changes in github check run#8226
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the schema publisher to clarify successful GitHub schema checks. It changes the check title from 'No breaking changes' to 'No blocking changes' and updates the writeChanges helper to annotate schema changes with their status, indicating if they are safe based on usage or have been approved. A corresponding changeset has also been added. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tags: |
n1ru4l
changed the title
| title = 'No breaking changes'; | ||
| summary = this.changesToMarkdown(changes); | ||
| shortSummaryFallback = this.changesToMarkdown(changes, false); | ||
| title = 'No blocking changes'; |
There was a problem hiding this comment.
nit: I don't remember we used this terminology in other places
Resolve conflicts in schema-publisher.ts and schema-publisher.spec.ts caused by upstream graphql-hive#8226 (parallel refactor of the github check-run summary): - Keep the contract-changes fix (graphql-hive#6954) via buildSchemaCheckSuccessGithubOutput, but call the now module-level `changesToMarkdown` and adopt the renamed 'No blocking changes' title from graphql-hive#8226. - Combine both test suites into one schema-publisher.spec.ts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2 participants
Background
This clarifies the message we show in case there a breaking changes, but the schema check passed.