Skip to content

feat: Attempt to use ninja #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
spotandjake wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: Attempt to use ninja #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74be507
feat: Attempt to use ninja
spotandjake Sep 3, 2026
d6acec4
feat: Attempt using esy built through cmake
spotandjake Sep 3, 2026
93948b9
feat: Attempt newer version of ninja
spotandjake Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/opam.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
ocaml-compiler: [4.13.1, 4.14.1, 5.3.0]
ocaml-compiler: [5.3.0]

steps:
- name: Setup node.js
Expand Down
16 changes: 8 additions & 8 deletions dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,15 @@
-B
binaryen
-G
"Unix Makefiles"
"Ninja"
; GCC 7 (shipped with esy) doesn't like _ for unused variables
"-DCMAKE_CXX_FLAGS=-Wno-unused-variable -Wno-maybe-uninitialized -Wno-deprecated-declarations -Wno-restrict"
-DBUILD_TESTS=OFF
-DBUILD_TOOLS=OFF
-DBUILD_SHARED_LIBS=OFF
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_INSTALL_PREFIX=binaryen)
(run cmake --build binaryen --config Release -- -j4)
(run ninja -C binaryen binaryen)
(copy binaryen/lib/libbinaryen.a libbinaryen.a)))))

(rule
Expand All @@ -66,15 +66,15 @@
-B
binaryen
-G
"Unix Makefiles"
"Ninja"
; GCC 7 (shipped with esy) doesn't like _ for unused variables
"-DCMAKE_CXX_FLAGS=-Wno-unused-variable -Wno-maybe-uninitialized -Wno-deprecated-declarations -Wno-restrict"
-DBUILD_TESTS=OFF
-DBUILD_TOOLS=OFF
-DBUILD_SHARED_LIBS=ON
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_INSTALL_PREFIX=binaryen)
(run cmake --build binaryen --config Release -- -j4)
(run ninja -C binaryen binaryen)
(copy binaryen/lib/libbinaryen.dylib dllbinaryen.so)))))

(rule
Expand All @@ -96,15 +96,15 @@
-B
binaryen
-G
"Unix Makefiles"
"Ninja"
; GCC 7 (shipped with esy) doesn't like _ for unused variables
"-DCMAKE_CXX_FLAGS=-Wno-unused-variable -Wno-maybe-uninitialized -Wno-restrict"
-DBUILD_TESTS=OFF
-DBUILD_TOOLS=OFF
-DBUILD_SHARED_LIBS=ON
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_INSTALL_PREFIX=binaryen)
(run cmake --build binaryen --config Release -- -j4)
(run ninja -C binaryen binaryen)
(copy binaryen/lib/libbinaryen.so dllbinaryen.so)))))

(rule
Expand All @@ -124,7 +124,7 @@
-B
binaryen
-G
"Unix Makefiles"
"Ninja"
-DCMAKE_C_COMPILER=x86_64-w64-mingw32-gcc
-DCMAKE_CXX_COMPILER=x86_64-w64-mingw32-g++
"-DCMAKE_SYSTEM_NAME=Windows"
Expand All @@ -136,7 +136,7 @@
-DBUILD_SHARED_LIBS=ON
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_INSTALL_PREFIX=binaryen)
(run cmake --build binaryen --config Release -- -j4)
(run ninja -C binaryen binaryen)
(copy binaryen/bin/libbinaryen.dll dllbinaryen.dll)))))

(data_only_dirs node_modules)
Loading
Loading