feat(compiler)!: Convert box from a tuple to a record - #2402
Open
spotandjake wants to merge 1 commit into
Open
Conversation
This pr changes the internal representation of the `Box<a>` type from a single value tuple to a record.
The main advantage of this change is we can now pattern match on the raw record `{ _value }` to pattern match on records directly.
I chose the name `_value` because it's easy to use but the `_` should help keep it from conflicting with user records.
The snapshot changed because we added a new identifier which changed the ordering.
Closes: #2308
spotandjake
requested review from
alex-snezhko,
marcusroberts,
peblair and
phated
as code owners
September 4, 2026 19:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr changes the internal representation of the
Box<a>type from a single value tuple to a record.The main advantage of this change is we can now pattern match on the raw record
{ _value }to pattern match on records directly.I chose the name
_valuebecause it's easy to use but the_should help keep it from conflicting with user records.The snapshot changed because we added a new identifier which changed the ordering.
I'm pretty sure this is considered breaking given we are changing an internal data structure, but from a user facing perspective because we never previously exposed the underlying tuple nature this shouldn't break any existing code outside of the runtime.
Closes: #2308